remove references to personal repositories #14178
Conversation
|
[test] |
| @@ -350,8 +350,6 @@ os::cmd::expect_success 'oc delete secret dbsecret' | |||
| os::cmd::expect_success_and_text 'oc new-app ruby-helloworld-sample -l app=helloworld -o name' 'service/frontend' | |||
| os::cmd::expect_success 'oc delete all -l app=helloworld' | |||
| os::cmd::expect_success 'oc delete secret dbsecret' | |||
| # create from template with code explicitly set is not supported | |||
| os::cmd::expect_failure 'oc new-app [email protected]:mfojtik/sinatra-app-example' | |||
There was a problem hiding this comment.
this was a totally broken test so i don't feel much guilt about just removing it outright.
There was a problem hiding this comment.
I've considered removing os::cmd::expect_failure for this reason...
|
@openshift/devex ptal |
|
Evaluated for origin test up to f01ec12 |
|
Evaluated for origin testextended up to f01ec12 |
|
Lgtm |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1414/) (Base Commit: 4f2b9d7) |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/385/) (Base Commit: 4f2b9d7) (Extended Tests: core(builds)) |
|
[merge] |
|
Evaluated for origin merge up to f01ec12 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/646/) (Base Commit: 8052ada) (Image: devenv-rhel7_6228) |
in partial fulfillment of #9899