Fix clientset group names #14203
Merged
Fix clientset group names #14203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
1 similar comment
|
[test] |
|
lgtm |
|
LGTM as well, nice catch. |
|
[merge] |
openshift-bot
added
the
needs-rebase
|
Evaluated for origin test up to 04c7eab |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1567/) (Base Commit: 74e1a68) |
|
continuous-integration/openshift-jenkins/test SUCCESS |
openshift-bot
removed
the
needs-rebase
|
[merge]
…On Thu, May 18, 2017 at 5:30 PM OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test SUCCESS
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14203 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABYnrXYyOw5Kn-WAPjqJYnBfGixig3ks5r7LhsgaJpZM4NbrU2>
.
|
|
Evaluated for origin merge up to 04c7eab |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/726/) (Base Commit: da1352d) (Image: devenv-rhel7_6247) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/deploy's API group name is apps.openshift.io, but the previous clientset generation keyed off of the directory name (deploy from pkg/deploy) to determine the group name incorrectly. This fixes that issue (and the same thing for pkg/sdn -> network.openshift.io).
Fixes #14183
@deads2k @liggitt @sttts @smarterclayton @mfojtik