Node DNS should answer PTR records for stateful sets #14400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
@openshift/networking |
|
[test] |
1 similar comment
|
[test] |
|
@sdodson this is dependent on DNS work |
knobunc
approved these changes
Jun 9, 2017
|
[test] |
smarterclayton
force-pushed
the
fix_endpoints
branch
from
915a2dc to
11f01b7
Compare
|
[severity:bug] |
smarterclayton
force-pushed
the
fix_endpoints
branch
from
11f01b7 to
e651574
Compare
A stateful set pod should be able to perform a PTR lookup on its IP and get its hostname (from the pod value) pointing back to its entry in the stateful set. Because multiple services can exist for a pod, we choose the oldest cached entry. This does *not* support the PTR lookup from the master due to the impact of keeping those objects in memory. We are in the process of transitioning to remove the master from the DNS chain.
smarterclayton
force-pushed
the
fix_endpoints
branch
from
e651574 to
b562284
Compare
|
merge as blocker? |
|
Waiting for changes from installer so this can be tested. |
|
[test] again to create new RPMs for @sdodson |
|
That'll persist rpms somewhere I can grab them? |
|
The gce job prints the URL of the repo
On Jun 21, 2017, at 1:40 PM, OpenShift Bot <[email protected]> wrote:
continuous-integration/openshift-jenkins/test Running (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2477/)
(Base Commit: 7461c10
<7461c10>)
(PR Branch Commit: b562284
<b562284>
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14400 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p-b2vB_JfybSDKaCbm_PU-Wvts3Hks5sGVVkgaJpZM4NppkR>
.
|
|
[test] |
|
[test] now that everything has landed |
|
Evaluated for origin test up to b562284 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2966/) (Base Commit: c9f829c) (PR Branch Commit: b562284) |
|
Tests are green with @sdodson 's changes in, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stateful set pod should be able to perform a PTR lookup on its IP and
get its hostname (from the pod value) pointing back to its entry in the
stateful set. Because multiple services can exist for a pod, we choose
the oldest cached entry.
This does not support the PTR lookup from the master due to the impact
of keeping those objects in memory. We are in the process of
transitioning to remove the master from the DNS chain.
Fixes #13866