Replace legacy IS informer with generated informers everywhere #14562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow them to be loaded via ForResource() as a stepping stone to transforming their behavior. Set projects and tokens as GC excluded resources (virtual, and security related).
Also make it available to GC. Remove "images" from GC for now.
smarterclayton
force-pushed
the
remove_imagestream_legacy
branch
from
00da5b6 to
c42f8b0
Compare
|
[test] |
|
Evaluated for origin test up to 78917fc |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2091/) (Base Commit: c9a1d10) |
|
Build flake |
|
@mfojtik this is part of a chain, please review image stream generator changes |
|
@smarterclayton LGTM good stuff. this will probably break you: #14317 (or you break me 👿 ) |
|
[merge] but I bet you beat me in |
|
Evaluated for origin merge up to 78917fc |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/968/) (Base Commit: e166740) (Image: devenv-rhel7_6338) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make it available to GC. Remove "images" from GC for now.
Only the last two commits are new to this PR.