UPSTREAM: <drop>: regenerate code #14594
Conversation
|
[test] |
| @@ -1,4 +1,20 @@ | |||
| // +build !ignore_autogenerated_openshift | |||
| // +build !ignore_autogenerated | |||
There was a problem hiding this comment.
why do we get the boilerplate now? Didn't we remove that before?
| @@ -65,8 +65,10 @@ func DeepCopy_wardle_FlunderList(in interface{}, out interface{}, c *conversion. | |||
| in, out := &in.Items, &out.Items | |||
| *out = make([]Flunder, len(*in)) | |||
| for i := range *in { | |||
| if err := DeepCopy_wardle_Flunder(&(*in)[i], &(*out)[i], c); err != nil { | |||
| if newVal, err := c.DeepCopy(&(*in)[i]); err != nil { | |||
There was a problem hiding this comment.
Interersting that we now go through the schema. Any idea why?
There was a problem hiding this comment.
we have the same upstream. Maybe a regression there, not critical, just slow.
|
I just re-ran the build in openshift/kubernetes and it produced this, which I then picked here. I didn't investigate what the generator did |
|
I was of the impression that we drop the boilerplate somewhere, but cannot find it. @stevekuznetsov do you remember? Other than that, lgtm. |
Well @sttts, I found it, but it won't make you happy. Looks like we have our own, separate, openshift generator too. Regenerated the regenerated code. This is nuts and its not even consistent between deep copy and conversion |
| @@ -16090,16 +16090,19 @@ func (x *ISCSIVolumeSource) CodecEncodeSelf(e *codec1978.Encoder) { | |||
| } else { | |||
| yysep2 := !z.EncBinary() | |||
| yy2arr2 := z.EncBasicHandle().StructToArray | |||
| var yyq2 [7]bool | |||
| var yyq2 [10]bool | |||
There was a problem hiding this comment.
I have no idea what that is doing.
There was a problem hiding this comment.
#14112 picked in API changes without regenerating files.
There was a problem hiding this comment.
And now I do and I wish I didn't. Ouch.
There was a problem hiding this comment.
And we have no verify-generated-code job in CI :-/
There was a problem hiding this comment.
I thought we did for the bits we expected to generate (proto, deep copy, conversion, etc). Previously, we removed generated ugorji in origin, and so we didn't care about generating it.
|
[merge][severity:blocker] to unstick @DirectXMan12 re[test] (edited by liggitt to add blocker) |
|
this LGTM, though we need a follow-up to remove all the types.generated.go files throughout the tree... those came in accidentally with the rebase |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 1 |
|
Evaluated for origin merge up to e5d76df |
|
Evaluated for origin test up to e5d76df |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2235/) (Base Commit: ee9f436) |
Requires openshift/kubernetes#31 .
This is needed or status changes don't take affect