NetworkCheck diagnostic: create projects with empty nodeselector #14686
Conversation
|
@pravisankar any concerns? I wasn't sure if specifying the one annotation was going to get in the way of whatever default annotations were supposed to be, but it doesn't look like it's a problem in my tests. |
fix bug 1431588 https://bugzilla.redhat.com/show_bug.cgi?id=1431588 fix bug 1459241 https://bugzilla.redhat.com/show_bug.cgi?id=1459241 When creating the projects in which the test pods will deploy, create them with an empty node selector so that they can run on any nodes, not just nodes with the cluster default node selector.
sosiouxme
force-pushed
the
20170615-network-diagnostic-selector
branch
from
7760b10 to
4ad8129
Compare
|
@sosiouxme No issues. Default node selector is only applied to the project if it doesn't have its own node selector. |
|
[merge][severity: bug] |
|
Evaluated for origin merge up to 4ad8129 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 4ad8129 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2302/) (Base Commit: a68db68) (PR Branch Commit: 4ad8129) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1030/) (Base Commit: 7b0131b) (PR Branch Commit: 4ad8129) (Extended Tests: bug) (Image: devenv-rhel7_6374) |
fix bug 1431588 https://bugzilla.redhat.com/show_bug.cgi?id=1431588
fix bug 1459241 https://bugzilla.redhat.com/show_bug.cgi?id=1459241
When creating the projects in which the test pods will deploy, create
them with an empty node selector so that they can run on any nodes, not
just nodes with the cluster default node selector.