Skip to content

make cgroup imports linux-only #14717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2017
Merged

make cgroup imports linux-only #14717

merged 1 commit into from
Jun 17, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 17, 2017

cgroups.ParseCgroupFile is only available on linux

fixes #14718

@liggitt
Copy link
Contributor Author

liggitt commented Jun 17, 2017

[test]

@liggitt
Copy link
Contributor Author

liggitt commented Jun 17, 2017

@bparees PTAL

@bparees
Copy link
Contributor

bparees commented Jun 17, 2017

lgtm
[testextended][extended:core(build with a quota)]

@bparees
Copy link
Contributor

bparees commented Jun 17, 2017

guess it's time to add cross-compiling checks to the merge queue? :(

@liggitt
Copy link
Contributor Author

liggitt commented Jun 17, 2017

guess it's time to add cross-compiling checks to the merge queue? :(

eh, it's rare and easy to fix when it happens

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to f3cc20b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/644/) (Base Commit: 8c017d2) (PR Branch Commit: f3cc20b) (Extended Tests: core(build with a quota))

@liggitt
Copy link
Contributor Author

liggitt commented Jun 17, 2017

[merge][severity:bug]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 17, 2017

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 5

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to f3cc20b

@bparees
Copy link
Contributor

bparees commented Jun 17, 2017 via email

@bparees
Copy link
Contributor

bparees commented Jun 17, 2017

in case anyone wants to investigate why the test took 6 hours, job was here:
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_integration/3355/

[test]

@bparees
Copy link
Contributor

bparees commented Jun 17, 2017

So up to the integration test stage, things should have only taken maybe an hour.

Within the integration test stage, I see no successful test taking longer than 84s (and most of them are sub 1s), meaning I don't see any individual tests that appeared to get "stuck" but ultimately pass after consuming a bunch of time.

And then at the end of the stage we just fail:

There was no error output from the command.
Running test/end-to-end/core.sh:387: executing 'oc delete pod cli-with-token' expecting success...
SUCCESS after 0.257s: test/end-to-end/core.sh:387: executing 'oc delete pod cli-with-token' expecting success
Standard output from the command:
pod "cli-with-token" deleted

There was no error output from the command.
Connection to 172.18.7.30 closed by remote host.
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: RUN INTEGRATION TESTS [06h 06m 30s] ##########

I don't know what that next command was that failed/hung or why.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to f3cc20b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2353/) (Base Commit: f12892b) (PR Branch Commit: f3cc20b)

@liggitt liggitt merged commit 7bee838 into openshift:master Jun 17, 2017
@liggitt liggitt deleted the cgroup-linux branch June 19, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/build/builder/util.go failed to compile on RHEL
3 participants