Skip to content

Add build pruning test for BuildPhaseError #14720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Add build pruning test for BuildPhaseError #14720

merged 1 commit into from
Jun 18, 2017

Conversation

coreydaley
Copy link

Closes #14390

@coreydaley
Copy link
Author

[test]

@coreydaley
Copy link
Author

coreydaley commented Jun 17, 2017

[testextended][extended:core(should prune errored builds)]

@coreydaley
Copy link
Author

@bparees ptal

@coreydaley
Copy link
Author

test/flake #13984

Copy link
Contributor

@bparees bparees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits to trim down your testdata object.

Also you don't need to run the full extended builds suite on this since you're just adding a new test, pick a filter that will just run your new test.

resources: {}
postCommit: {}
nodeSelector: null
status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete these last 4 lines, they don't serve any purpose.

openshift.io/generated-by: OpenShiftWebConsole
spec:
failedBuildsHistoryLimit: 2
triggers: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this line

output:
to:
kind: ImageStreamTag
name: 'myphp:latest'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the output, it's not needed right? (won't even try to push there since the build errors out)

spec:
failedBuildsHistoryLimit: 2
triggers: {}
runPolicy: Serial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default, you don't need to specify it.

labels:
app: myphp
annotations:
openshift.io/generated-by: OpenShiftWebConsole
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need these labels or annotations.

@bparees bparees self-assigned this Jun 18, 2017
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 3037ae5

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 3037ae5

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/649/) (Base Commit: 2d90d52) (PR Branch Commit: 3037ae5) (Extended Tests: core(should prune errored builds))

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2370/) (Base Commit: 2d90d52) (PR Branch Commit: 3037ae5)

@coreydaley
Copy link
Author

@bparees updated per your suggestions

@bparees
Copy link
Contributor

bparees commented Jun 18, 2017

[merge][severity:bug]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 3037ae5

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 18, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1040/) (Base Commit: fa750b9) (PR Branch Commit: 3037ae5) (Extended Tests: bug) (Image: devenv-rhel7_6374)

@openshift-bot openshift-bot merged commit 04c4ce3 into openshift:master Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants