-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add build pruning test for BuildPhaseError #14720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build pruning test for BuildPhaseError #14720
Conversation
[test] |
[testextended][extended:core(should prune errored builds)] |
@bparees ptal |
test/flake #13984 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits to trim down your testdata object.
Also you don't need to run the full extended builds suite on this since you're just adding a new test, pick a filter that will just run your new test.
resources: {} | ||
postCommit: {} | ||
nodeSelector: null | ||
status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete these last 4 lines, they don't serve any purpose.
openshift.io/generated-by: OpenShiftWebConsole | ||
spec: | ||
failedBuildsHistoryLimit: 2 | ||
triggers: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this line
output: | ||
to: | ||
kind: ImageStreamTag | ||
name: 'myphp:latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete the output, it's not needed right? (won't even try to push there since the build errors out)
spec: | ||
failedBuildsHistoryLimit: 2 | ||
triggers: {} | ||
runPolicy: Serial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the default, you don't need to specify it.
labels: | ||
app: myphp | ||
annotations: | ||
openshift.io/generated-by: OpenShiftWebConsole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need these labels or annotations.
Evaluated for origin test up to 3037ae5 |
Evaluated for origin testextended up to 3037ae5 |
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/649/) (Base Commit: 2d90d52) (PR Branch Commit: 3037ae5) (Extended Tests: core(should prune errored builds)) |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2370/) (Base Commit: 2d90d52) (PR Branch Commit: 3037ae5) |
@bparees updated per your suggestions |
[merge][severity:bug] |
Evaluated for origin merge up to 3037ae5 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1040/) (Base Commit: fa750b9) (PR Branch Commit: 3037ae5) (Extended Tests: bug) (Image: devenv-rhel7_6374) |
Closes #14390