Use preferred version when encoding nested objects

[liggitt]

Fixes #14820

When we have a preferred version for encoding, make it available to nested object encoders

[liggitt]

@enj @smarterclayton PTAL

[liggitt]

[test]

[liggitt]

manually tested with json and protobuf watches of grouped and ungrouped authorization API... thinking through the best way to test this generically

for posterity:

curl "https://localhost:8443/oapi/v1/clusterpolicies?watch=true" -k -H "Accept: application/vnd.kubernetes.protobuf"
curl "https://localhost:8443/oapi/v1/clusterpolicies?watch=true" -k -H "Accept: application/json"
curl "https://localhost:8443/apis/authorization.openshift.io/v1/clusterpolicies?watch=true" -k -H "Accept: application/vnd.kubernetes.protobuf"
curl "https://localhost:8443/apis/authorization.openshift.io/v1/clusterpolicies?watch=true" -k -H "Accept: application/json"

[enj]

LGTM, look forward to the magical test required to prevent this...

[smarterclayton]

LGTM. I think the encode version was added later than the DirectEncoder was created, possibly leading to this.

[openshift-bot]

Evaluated for origin test up to 53bfdcc

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2572/) (Base Commit: 9b2743f) (PR Branch Commit: 53bfdcc)

[enj]

[merge][severity:blocker]

[enj]

Flake #9309

[smarterclayton]

TF?

[merge] you flearidden bot

[enj]

I had it as a bug and edited it to blocker after I realized we were frozen.

[openshift-bot]

Evaluated for origin merge up to 53bfdcc

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1131/) (Base Commit: bb817e0) (PR Branch Commit: 53bfdcc) (Extended Tests: blocker) (Image: devenv-rhel7_6396)