Skip to content

oc new-app --build-env doesn't work on templates #14922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2017
Merged

oc new-app --build-env doesn't work on templates #14922

merged 1 commit into from
Jul 2, 2017

Conversation

coreydaley
Copy link
Member

Fixes #14906

@coreydaley
Copy link
Member Author

coreydaley commented Jun 27, 2017 •
edited
Loading

[test][testextended][extended:core(builds)]

@coreydaley
Copy link
Member Author

@openshift/devex ptal
@jim-minter fyi

bparees
bparees requested changes Jun 27, 2017
View reviewed changes
pkg/generate/app/cmd/newapp.go Outdated
buildEnv := buildutil.GetBuildConfigEnv(result.Objects[i].(*buildapi.BuildConfig))
buildEnv = app.JoinEnvironment(buildEnv, buildEnvironment.List())
buildutil.SetBuildConfigEnv(result.Objects[i].(*buildapi.BuildConfig), buildEnv)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a type switch like GetPodSpec does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@bparees bparees self-assigned this Jun 27, 2017
bparees
bparees requested changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@bparees bparees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test case to newapp.sh please.

@coreydaley
Copy link
Member Author

test/flake #14043

@coreydaley
Copy link
Member Author

@bparees test case added

@bparees
Copy link
Contributor

bparees commented Jun 28, 2017

[merge]

@bparees
Copy link
Contributor

bparees commented Jun 30, 2017 via email

@bparees
Copy link
Contributor

bparees commented Jun 30, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 1b648eb

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 1b648eb

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2896/) (Base Commit: 57a4d50) (PR Branch Commit: 1b648eb)

@bparees
Copy link
Contributor

bparees commented Jun 30, 2017

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/805/) (Base Commit: 57a4d50) (PR Branch Commit: 1b648eb) (Extended Tests: core(builds))

@bparees
Copy link
Contributor

bparees commented Jul 2, 2017 via email

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 1b648eb

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 2, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1212/) (Base Commit: 60caae1) (PR Branch Commit: 1b648eb) (Image: devenv-rhel7_6419)

@openshift-bot openshift-bot merged commit 95ca0bb into openshift:master Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees approved these changes

Assignees

@bparees bparees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coreydaley @bparees @openshift-bot