Update lastTriggeredImage if not set when instantiating DCs #15145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the endpoint will think that the image is missing from the cluster in cases where the image hash is already set but the lastTriggeredImage is not set. Signed-off-by: Michail Kargakis <[email protected]>
|
[test] |
|
Evaluated for origin test up to 56c4920 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3050/) (Base Commit: 1c8af8b) (PR Branch Commit: 56c4920) |
|
LGTM [severity:blocker] direct merge |
0xmichalis
deleted the
fix-instantiating-templates-with-real-images-master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the endpoint will think that the image is missing
from the cluster in cases where the image hash is already set
but the lastTriggeredImage is not set.
Signed-off-by: Michail Kargakis [email protected]