Skip to content

Tighten up config #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2015
Merged

Tighten up config #1532

merged 1 commit into from
Apr 2, 2015

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Apr 1, 2015

@deads2k review

  • unnest usage object
  • restore stomped remoteconnection conversion
  • shorten providerName to name
  • rename logoutURI to logoutURL for consistency, and validate url
  • give the names of conflicting providers when more than one claims login ability
  • change RequestHeaderIdentityProvider to use a string slice for headers, since we need to check headers in specified order
  • Validate no provider name duplicates

Follow-ups:

  • Add conversion tests
  • Secret config - moved session secret changes to separate PR to work on externalization

Before:

oauthConfig:
  ...
  identityProviders:
  - provider:
      apiVersion: v1
      kind: AllowAllPasswordIdentityProvider
    usage:
      challenge: true
      login: true
      providerName: anypassword

After:

oauthConfig:
  ...
  identityProviders:
  - challenge: true
    login: true
    name: anypassword
    provider:
      apiVersion: v1
      kind: AllowAllPasswordIdentityProvider

@liggitt liggitt changed the title Tighten up identity provider config Tighten up config Apr 1, 2015
@deads2k
Copy link
Contributor

deads2k commented Apr 1, 2015

Beauty is in the eye of the beholder...

deads2k
deads2k reviewed Apr 1, 2015
View reviewed changes
pkg/cmd/server/api/types.go
type IdentityProviderUsage struct {
// ProviderName is used to qualify the identities returned by this provider
ProviderName string
type SessionSecret struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

externalize secrets

@deads2k
Copy link
Contributor

deads2k commented Apr 1, 2015

Externalize secrets and get issues or pulls open for the todos. Other than that, lgtm.

Don't forget to update 275 with the session secret changes.

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@liggitt
Copy link
Contributor Author

liggitt commented Apr 1, 2015

re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 0fd3525

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1671/) (Image: devenv-fedora_1189)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1671/)

openshift-bot pushed a commit that referenced this pull request Apr 2, 2015
Merge pull request #1532 from liggitt/unnest_idp_usage
d4c2891 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit d4c2891 into openshift:master Apr 2, 2015
@liggitt liggitt deleted the unnest_idp_usage branch April 2, 2015 19:18
@liggitt liggitt mentioned this pull request Apr 11, 2015
Closed
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Nov 19, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
60e970d 
…service-catalog/' changes from 3064247d05..d969acde90

d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
1bcd53b684 origin build: add origin tooling
bb3e4a1 Chart changes for 0.1.3 (openshift#1573)
1d463c3 less etcd logs during integration test (openshift#1572)
dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568)
b636203 make binding poll function clone binding (openshift#1550)
e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536)
4f47ce8 Embed etcd in the integration tests directly. (openshift#1570)
d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519)
31ae521 Check if file permissions allow go install (openshift#1566)
52e64db Clear out plan ref when plan changed using k8s names (openshift#1553)
4b49594 Allow deprovision after change to non-existent plan (openshift#1557)
c6e446e Consolidating logic for creating in-progress properties. (openshift#1511)
fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544)
b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538)
c8d5610 update comments on NewStorage (openshift#1548)
35082df Update resources in walkthrough (openshift#1510)
f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543)
02a5ff6 Add an additional plan to ups-broker (openshift#1537)
4309a0e add alpha asynchronous binding operation support (openshift#1512)
617c823 Grant controller abilit to update service/plan status (openshift#1532)
281ca9c Moving a duplicated block of code to an independent function. (openshift#1509)
da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507)
48c522d Updating helm install documentation (openshift#1525)
b89d59e Adding an independent test for originating_identity (openshift#1498)
6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497)
411831c Fixing missing pretty logging on controller_binding. (openshift#1520)
REVERT: 3064247d05 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Nov 20, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
cee61f2 
…service-catalog/' changes from 3064247d05..d969acde90

d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
1bcd53b684 origin build: add origin tooling
bb3e4a1 Chart changes for 0.1.3 (openshift#1573)
1d463c3 less etcd logs during integration test (openshift#1572)
dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568)
b636203 make binding poll function clone binding (openshift#1550)
e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536)
4f47ce8 Embed etcd in the integration tests directly. (openshift#1570)
d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519)
31ae521 Check if file permissions allow go install (openshift#1566)
52e64db Clear out plan ref when plan changed using k8s names (openshift#1553)
4b49594 Allow deprovision after change to non-existent plan (openshift#1557)
c6e446e Consolidating logic for creating in-progress properties. (openshift#1511)
fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544)
b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538)
c8d5610 update comments on NewStorage (openshift#1548)
35082df Update resources in walkthrough (openshift#1510)
f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543)
02a5ff6 Add an additional plan to ups-broker (openshift#1537)
4309a0e add alpha asynchronous binding operation support (openshift#1512)
617c823 Grant controller abilit to update service/plan status (openshift#1532)
281ca9c Moving a duplicated block of code to an independent function. (openshift#1509)
da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507)
48c522d Updating helm install documentation (openshift#1525)
b89d59e Adding an independent test for originating_identity (openshift#1498)
6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497)
411831c Fixing missing pretty logging on controller_binding. (openshift#1520)
REVERT: 3064247d05 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Dec 15, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
cedd00c 
…service-catalog/' changes from 3064247d05..d969acde90

d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
1bcd53b684 origin build: add origin tooling
bb3e4a1 Chart changes for 0.1.3 (openshift#1573)
1d463c3 less etcd logs during integration test (openshift#1572)
dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568)
b636203 make binding poll function clone binding (openshift#1550)
e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536)
4f47ce8 Embed etcd in the integration tests directly. (openshift#1570)
d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519)
31ae521 Check if file permissions allow go install (openshift#1566)
52e64db Clear out plan ref when plan changed using k8s names (openshift#1553)
4b49594 Allow deprovision after change to non-existent plan (openshift#1557)
c6e446e Consolidating logic for creating in-progress properties. (openshift#1511)
fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544)
b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538)
c8d5610 update comments on NewStorage (openshift#1548)
35082df Update resources in walkthrough (openshift#1510)
f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543)
02a5ff6 Add an additional plan to ups-broker (openshift#1537)
4309a0e add alpha asynchronous binding operation support (openshift#1512)
617c823 Grant controller abilit to update service/plan status (openshift#1532)
281ca9c Moving a duplicated block of code to an independent function. (openshift#1509)
da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507)
48c522d Updating helm install documentation (openshift#1525)
b89d59e Adding an independent test for originating_identity (openshift#1498)
6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497)
411831c Fixing missing pretty logging on controller_binding. (openshift#1520)
REVERT: 3064247d05 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
@pmorie @kibbles-n-bytes
Grant controller abilit to update service/plan status (openshift#1532)
617c823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @deads2k @openshift-bot