Skip to content

Truncate rev.Git.Message on the first line #15514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2017
Merged

Truncate rev.Git.Message on the first line #15514

merged 1 commit into from
Jul 30, 2017

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Jul 27, 2017

Fixes #13841

@openshift-ci-robot
Copy link

Hi @matthyx. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2017
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2017
@0xmichalis
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@matthyx
Copy link
Contributor Author

matthyx commented Jul 29, 2017

/cc @bparees

@0xmichalis 0xmichalis removed their assignment Jul 29, 2017
@bparees
Copy link
Contributor

bparees commented Jul 29, 2017

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2017
@bparees bparees added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, matthyx

Associated issue: 13841

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor

bparees commented Jul 29, 2017

flake #14385
/retest

@bparees
Copy link
Contributor

bparees commented Jul 30, 2017

flake 2017-07-30T03:41:54.115379000Z F0730 03:41:54.114669 1 helpers.go:119] error: build error: fatal: unable to access 'https://github.com/openshift/ruby-hello-world/': Could not resolve host: github.com; Unknown error

presumably a network issue, possibly an issue w/ GCe provisioning in general.

/retest

@bparees
Copy link
Contributor

bparees commented Jul 30, 2017

flake #15548
/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit de23676 into openshift:master Jul 30, 2017
@matthyx matthyx deleted the issue-13841 branch August 19, 2017 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/P2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants