UPSTREAM: googleapis/gnostic/compiler: 00000: Bad perf

[smarterclayton]

Detected in #15326

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smarterclayton

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[smarterclayton]

@deads2k this was 6 million allocations during integration test start (out of about 16 million total). I think that might shave as much as a third off the total time remaining on integration (rerunning the bits).

[deads2k]

@deads2k this was 6 million allocations during integration test start (out of about 16 million total). I think that might shave as much as a third off the total time remaining on integration (rerunning the bits).

Heh, ouch. Want to compare against my big hammer? #15537 We don't actually need openapi for integration tests

[smarterclayton]

I figured out what he was using the regex for. String prefixes. So I'm going to fix that and get a good upstream. I don't think we'll have to turn off open api after that, but I was not seeing it in my profiles after I fixed the obvious stuff.

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smarterclayton

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[deads2k]

I figured out what he was using the regex for. String prefixes. So I'm going to fix that and get a good upstream. I don't think we'll have to turn off open api after that, but I was not seeing it in my profiles after I fixed the obvious stuff.

My pull got test-integration to 90 minutes, this one is at 110 minutes.

[smarterclayton]

Might be useful to know where that 20s is coming from.