Separate e2e-user config file in end to end #1563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1639/) |
|
Hrm, project should switch contexts normally (if you know the context name). So then it's just a matter of login not properly making the transition from the initial config object to a different user and context. |
|
I'll merge it direct when the tests pass |
|
[test] |
|
I just manually merged this into my dev branch locally and e2e passes for me. |
|
[test] |
|
Evaluated for origin up to 16df0e8 |
danmcp
added a commit
that referenced
this pull request
Apr 2, 2015
Separate e2e-user config file in end to end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fabianofranz review
osc project masterisn't working to switch back to thesystem:adminuser frome2e-userin test-end-to-end.sh. I'm really not sure how it ever worked. It's resulting in these errors:Once you start messing with the context of a cluster admin's config file, there's no way to get back using
osc loginandosc projectcommands... you need to doosc config use-context master --kubeconfig=.... That seems wonky enough that I just made e2e use separate config files for the cluster user and the e2e user.