Skip to content

add test case for private image source inputs #16044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2017
Merged

add test case for private image source inputs #16044

merged 1 commit into from
Aug 31, 2017

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Aug 29, 2017

No description provided.

@bparees
Copy link
Contributor Author

bparees commented Aug 29, 2017

@csrwng @jim-minter ptal

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2017
@bparees
Copy link
Contributor Author

bparees commented Aug 29, 2017

@csrwng @jim-minter ptal

@csrwng
Copy link
Contributor

csrwng commented Aug 29, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2017
@bparees
Copy link
Contributor Author

bparees commented Aug 30, 2017

@csrwng unexpected failure pulling images here too:
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_builds/157/testReport/junit/(root)/Extended/_builds__Slow__build_can_have_Docker_image_source_build_with_image_source_should_complete_successfully_and_contain_the_expected_file/

did you get to the bottom of what you were seeing?

@bparees
Copy link
Contributor Author

bparees commented Aug 30, 2017

@csrwng nm, but secrets are still broken, not sure how/why it worked for you (I think it'll only work today if the image already exists on the node). will have a fix in this PR shortly.

@bparees
Copy link
Contributor Author

bparees commented Aug 30, 2017

@csrwng updated, ptal.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2017
@bparees
Copy link
Contributor Author

bparees commented Aug 30, 2017

@jim-minter ptal

@bparees
Copy link
Contributor Author

bparees commented Aug 30, 2017

/retest

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2017
@0xmichalis 0xmichalis removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2017
@0xmichalis 0xmichalis closed this Aug 30, 2017
@0xmichalis 0xmichalis reopened this Aug 30, 2017
@bparees
Copy link
Contributor Author

bparees commented Aug 30, 2017

/retest

@jim-minter
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, csrwng, jim-minter

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor Author

bparees commented Aug 31, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 665899f into openshift:master Aug 31, 2017
@bparees bparees deleted the imagesource branch September 15, 2017 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jim-minter jim-minter

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bparees @csrwng @jim-minter @openshift-merge-robot @mfojtik @0xmichalis @openshift-ci-robot