Make admin project creation wait for SAR #16849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a SAR check to direct project creation to ensure that the designated user can get the project which was created for them. It also updates the project integration tests to be more tolerant of the project ACL being out of date. This race condition became more apparent as we moved to the generated clients since those clients were smaller and had their own rate limiters (instead of a one big client that could do everything and shared the same rate limiter). Since the new clients would perform actions at a faster pace, the race against the project ACL would occur more frequently. Signed-off-by: Monis Khan <[email protected]>
openshift-ci-robot
added
kind/bug
|
/approve
|
openshift-merge-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, mrogers950, smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a SAR check to direct project creation to ensure that the designated user can get the project which was created for them. It also updates the project integration tests to be more tolerant of the project ACL being out of date. This race condition became more apparent as we moved to the generated clients since those clients were smaller and had their own rate limiters (instead of a one big client that could do everything and shared the same rate limiter). Since the new clients would perform actions at a faster pace, the race against the project ACL would occur more frequently.
Signed-off-by: Monis Khan [email protected]
Fixes #16716
/kind bug
/assign @smarterclayton @simo5 @deads2k