move pkg/cmd/util/clientcmd -> pkg/oc/cli/util/clientcmd

[juanvallejo]

This patch partially solves a few of the items (currently checked) from #17309
Now that clientcmd (which includes printer factory methods) is moved into pkg/oc,
the following files outside of pkg/oc need to have their dependency on clientcmd broken (this will be done in a separate PR):

• pkg/cmd/server/origin/controller/config.go (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/cmd/server/admin/create_error_template.go (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/cmd/server/admin/create_bootstrap_project_template.go (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/cmd/server/admin/overwrite_bootstrappolicy.go (this file has been removed by Remove overwrite_bootstrappolicy and pkg/cmd/server/admin/legacyetcd #17336)
• pkg/cmd/server/admin/create_login_template.go (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/cmd/server/admin/create_provider_selection_template.go (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/cmd/infra/router/template.go (Wanted by: pkg/cmd/openshift/openshift.go (no other dependents)) (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/cmd/infra/router/f5.go (Wanted by: pkg/cmd/openshift/openshift.go (no other dependents)) (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/cmd/openshift/openshift.go (move "openshift ex" -> "oc ex" #17486 and remove openshift infra command #17482)
• pkg/cmd/dockerregistry/dockerregistry.go (Wanted by: cmd/dockerregistry/main.go (depends on clientcmd.Config)) (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/diagnostics/networkpod/util/util.go (Can be addressed by moving pkg/diagnostics inside existing pkg/oc/admin/diagnostics) move pkg/diagnostices -> pkg/oc/admin/diagnostics #17393
• pkg/diagnostics/client/config_contexts.go (Can be addressed by moving pkg/diagnostics inside existing pkg/oc/admin/diagnostics) move pkg/diagnostices -> pkg/oc/admin/diagnostics #17393
• pkg/diagnostics/client/run_diagnostics_pod.go (Can be addressed by moving pkg/diagnostics inside existing pkg/oc/admin/diagnostics) move pkg/diagnostices -> pkg/oc/admin/diagnostics #17393
• pkg/diagnostics/pod/auth.go (Can be addressed by moving pkg/diagnostics inside existing pkg/oc/admin/diagnostics) move pkg/diagnostices -> pkg/oc/admin/diagnostics #17393
• pkg/diagnostics/network/run_pod.go (Can be addressed by moving pkg/diagnostics inside existing pkg/oc/admin/diagnostics) move pkg/diagnostices -> pkg/oc/admin/diagnostics #17393
• pkg/ipfailover/keepalived/plugin.go (moved to pkg/oc/experimental) (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/federation/kubefed/kubefed.go (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/dockerregistry/server/client/client.go (break dep on clientcmd in pkgs outside pkg oc #17357)
• pkg/dockerregistry/server/auth_test.go (break dep on clientcmd in pkgs outside pkg oc #17357)

bold = depends on clientcmd.Config (not sure what to do about this) AND only dependent is pkg/cmd/openshift/openshift.go

cc @deads2k @openshift/cli-review @liggitt

[deads2k]

Check for conflicts with the rebase and get it green. This is an ok way to break the dependency. A little messy in the interm, but acceptable since we know you won't stop part way.

/approve no-issue

[deads2k]

let's crack some eggs.

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/OWNERS [deads2k]
• test/integration/OWNERS [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[juanvallejo]

/test extended_conformance_install

[juanvallejo]

/test extended_clusterup

[deads2k]

@juanvallejo this pull still valid/needed?

[juanvallejo]

@deads2k

this pull still valid/needed?

yes, this pull is a counterpart to #17357. This one moves clientcmd into pkg/oc, and pull/17357 breaks any package dependencies on it outside of pkg/oc

[juanvallejo]

/test extended_clusterup

[juanvallejo]

/test extended_clusterup

[juanvallejo]

/retest

[juanvallejo]

/retest

[juanvallejo]

/retest

[juanvallejo]

/test extended_conformance_install_update

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-ci-robot]

@juanvallejo: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_clusterup	8f3978b	link	/test extended_clusterup
ci/openshift-jenkins/extended_conformance_install_update	8f3978b	link	/test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue.