Skip to content

ovs: add OWNERS file #18241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

ovs: add OWNERS file #18241

merged 1 commit into from
Jan 23, 2018

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Jan 23, 2018 •
edited
Loading

We might as well own this.

@knobunc @eparis @openshift/networking

@openshift-ci-robot openshift-ci-robot added retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2018
deads2k
deads2k reviewed Jan 23, 2018
View reviewed changes
pkg/util/ovs/OWNERS Outdated
approvers:
- pravisankar
- dcbw
- smarterclayton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top level owners don't have to explicitly called out.

deads2k
deads2k reviewed Jan 23, 2018
View reviewed changes
pkg/util/ovs/OWNERS Outdated
reviewers:
- pravisankar
- dcbw
- smarterclayton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless he actually authored/directly owns the code in the package, you can leave him off of reviewers, to leave first level review to the core team that owns it.

@deads2k
Copy link
Contributor

deads2k commented Jan 23, 2018

nits

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2018
@dcbw dcbw force-pushed the pkg-util-ovs-OWNERS branch from c02fbc1 to 58c28f8 Compare January 23, 2018 18:19
@dcbw
Copy link
Contributor Author

dcbw commented Jan 23, 2018

@deads2k thanks, removed Clayton since he doesn't author/own code in pkg/util/ovs.

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2018
@knobunc
Copy link
Contributor

knobunc commented Jan 23, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, deads2k, knobunc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@knobunc
Copy link
Contributor

knobunc commented Jan 23, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit ac265ea into openshift:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@bparees bparees Awaiting requested review from bparees

Assignees

@stevekuznetsov stevekuznetsov

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dcbw @deads2k @stevekuznetsov @knobunc @openshift-ci-robot @openshift-merge-robot