return gone on unbind from non-existent templateinstance #18416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/S
bparees
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Looks correct to me per the open service broker spec |
bparees
changed the title
bparees
force-pushed
the
tsb_binding
branch
2 times, most recently
from
8249c88 to
8bfa1c4
Compare
bparees
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
disabled the new test for now since it won't pass until the TSB changes make it into a published image. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jim-minter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
GCP job updated to force log level 5. |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
Automatic merge from submit-queue. |
openshift-merge-robot
added a commit
that referenced
this pull request
Feb 7, 2018
Automatic merge from submit-queue. make sure we can unbind a deleted templateinstance won't pass tests until #18416 has merged and new images are pushed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug 1540819
https://bugzilla.redhat.com/show_bug.cgi?id=1540819