Don't try to delete (nonexistent) OVS flows for headless/external services #18879
Conversation
danwinship
added
kind/bug
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-3.9 |
|
@pravisankar: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@danwinship: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 18494, 18879, 18844, 18886). |
|
@pravisankar: new pull request created: #18890 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…-18879-to-release-3.9 Automatic merge from submit-queue. [release-3.9] Don't try to delete (nonexistent) OVS flows for headless/external services This is an automated cherry-pick of #18879 /assign pravisankar
When moving to shared informers in 3.6, the check to ignore events for headless/external services accidentally got limited to only add events, not delete, so now Online logs lots of errors like:
(That's for deleting an ExternalName service; trying to delete a headless service gives
ovs-ofctl: None: invalid IP address.) In either case, the bug is harmless other than the spurious error message; we're just failing to delete a flow that wasn't there anyway.