Skip to content

Add Casey Callendrello (squeed) to the relevant OWNERS files #19924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2018
Merged

Add Casey Callendrello (squeed) to the relevant OWNERS files #19924

merged 1 commit into from
Jun 10, 2018

Conversation

knobunc
Copy link
Contributor

@knobunc knobunc commented Jun 6, 2018

As SDN team lead Casey should be able to sign-off and approve PRs.

@knobunc knobunc self-assigned this Jun 6, 2018
@knobunc knobunc requested a review from stevekuznetsov June 6, 2018 15:52
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2018
@knobunc
Copy link
Contributor Author

knobunc commented Jun 6, 2018

@squeed FYI

@danwinship
Copy link
Contributor

I object on the grounds that his github profile misspells "Red Hat" as "RedHat" :-P

@knobunc
Copy link
Contributor Author

knobunc commented Jun 6, 2018

/retest

@knobunc
Add Casey Callendrello (squeed) to the relevant OWNERS files
0e144c6 
As SDN team lead Casey should be able to sign-off and approve PRs.
@knobunc knobunc force-pushed the fix/add-cdc-to-OWNERS branch from 2920d15 to 0e144c6 Compare June 7, 2018 12:53
@squeed
Copy link
Contributor

squeed commented Jun 7, 2018 •
edited
Loading

GitHub bio fixed, please review and spawn 1000 test VMs.

@knobunc
Copy link
Contributor Author

knobunc commented Jun 8, 2018

@smarterclayton can you LGTM this please?

@smarterclayton
Copy link
Contributor

smarterclayton commented Jun 10, 2018 via email

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 166c5f7 into openshift:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@danwinship danwinship Awaiting requested review from danwinship

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@knobunc @danwinship @squeed @smarterclayton @openshift-ci-robot @openshift-bot @openshift-merge-robot