Skip to content

re-enable slave restart test #20021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2018
Merged

re-enable slave restart test #20021

merged 1 commit into from
Jun 19, 2018

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jun 15, 2018 •
edited
Loading

sclorg/mysql-container#226 is fixed so re-enabling this.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2018
@bparees
Copy link
Contributor Author

bparees commented Jun 15, 2018

/assign @gabemontero

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2018
@bparees
Copy link
Contributor Author

bparees commented Jun 15, 2018

missed an import. fixed/re-lgtmed.

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2018
@bparees
Copy link
Contributor Author

bparees commented Jun 15, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2018
@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees mentioned this pull request Jun 18, 2018
Merged
@bparees
Copy link
Contributor Author

bparees commented Jun 19, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9c74c08 into openshift:master Jun 19, 2018
@bparees
Copy link
Contributor Author

bparees commented Jun 22, 2018

/cherry-pick release-3.10

@smarterclayton this should fix imageecosystem in 3.10

@bparees
Copy link
Contributor Author

bparees commented Jun 22, 2018

/cherrypick release-3.10

@bparees bparees mentioned this pull request Jun 22, 2018
Closed
@openshift-cherrypick-robot
Copy link

@bparees: #20021 failed to apply on top of branch "release-3.10":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/image_ecosystem/mysql_replica.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/image_ecosystem/mysql_replica.go
CONFLICT (content): Merge conflict in test/extended/image_ecosystem/mysql_replica.go
Patch failed at 0001 re-enable slave restart test

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees deleted the mysql_replica branch June 23, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero gabemontero approved these changes

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bparees @gabemontero @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot