Skip to content

Switch all commands to IOStreams #20122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 28, 2018

/assign @deads2k @juanvallejo

This should go in as soon as the rebase lands, since this is switching all our commands to IOStreams.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2018
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 28, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2018

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_image_registry 78d5fbf link /test extended_image_registry

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Jun 28, 2018

@soltysh @juanvallejo I picked this with the intent to merge it, but as I was reading, I wondered why wouldn't we tackle this the way we did in kubectl, where the first touch was to start creating the options we needed and iterate through the commands so we didn't need to re-touch them every time. This plumbs an arg, but then it effectively hides those which use it properly and those which don't.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2018
@soltysh soltysh changed the title WIP: Switch all commands to IOStreams Switch all commands to IOStreams Jun 28, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2018
@deads2k
Copy link
Contributor

deads2k commented Jun 28, 2018

@soltysh promised to make his future pulls establish options structs. I'm going to hold future pulls to that standard.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 28, 2018
@deads2k
Copy link
Contributor

deads2k commented Jun 28, 2018

wide breadth, requested (and denied) to come in with the rebase, work is stacked up behind it, bumping priority.

@openshift-merge-robot openshift-merge-robot merged commit b3160b9 into openshift:master Jun 29, 2018
@soltysh soltysh deleted the iostreams branch June 29, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants