-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Switch all commands to IOStreams #20122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@soltysh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@soltysh @juanvallejo I picked this with the intent to merge it, but as I was reading, I wondered why wouldn't we tackle this the way we did in kubectl, where the first touch was to start creating the options we needed and iterate through the commands so we didn't need to re-touch them every time. This plumbs an arg, but then it effectively hides those which use it properly and those which don't. |
@soltysh promised to make his future pulls establish options structs. I'm going to hold future pulls to that standard. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wide breadth, requested (and denied) to come in with the rebase, work is stacked up behind it, bumping priority. |
/assign @deads2k @juanvallejo
This should go in as soon as the rebase lands, since this is switching all our commands to
IOStreams
.