Skip to content

bump pkgs to release-3.11 #20899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

bump pkgs to release-3.11 #20899

merged 1 commit into from
Sep 11, 2018

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Sep 7, 2018 •
edited
Loading

  • Updates api, client-go, library-go, service-serving-cert-signer deps to release-3.11
  • Runs glide update
  • Pins updated lock file deps to glide.yaml

Note: ./hack/update-deps.sh moved the package github.com/elazarl/goproxy from the testImports section to the imports section in the glide.lock file. Its version hash c4fc26588b6ef8af07a191fcb6476387bdd46711 remains unchanged. I have made a note of this in the commit message as well.

cc @deads2k

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2018
@juanvallejo juanvallejo mentioned this pull request Sep 7, 2018
Closed
deads2k
deads2k reviewed Sep 7, 2018
View reviewed changes
glide.lock Outdated
@@ -96,7 +96,7 @@ imports:
- name: github.com/blang/semver
version: b38d23b8782a487059e8fc8773e9a5b228a77cb6
- name: github.com/certifi/gocertifi
version: deb3ae2ef2610fde3330947281941c562861188b
version: ee1a9a0726d2ae45f54118cac878c990d4016ded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these changing?

@juanvallejo
Copy link
Contributor Author

@deads2k

  • Pinned existing deps,
  • updated api, client-go, library-go, service-serving-cert-signer deps to release-3.11,
  • ran ./hack/update-deps.sh

deads2k
deads2k reviewed Sep 7, 2018
View reviewed changes
glide.lock
@@ -385,6 +385,8 @@ imports:
- spdy
- name: github.com/elazarl/go-bindata-assetfs
version: 3dcc96556217539f50599357fb481ac0dc7439b9
- name: github.com/elazarl/goproxy
version: c4fc26588b6ef8af07a191fcb6476387bdd46711
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanvallejo figure out what added this. I don't see other corresponding changes. Can you just reset your entire branch to release-3.11 and start over?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per off-thread conversation, this package was moved from the testImports section when ./hack/update-deps.sh was run.

@deads2k
Copy link
Contributor

deads2k commented Sep 7, 2018

@juanvallejo has the content here changed again?

@juanvallejo juanvallejo force-pushed the jvallejo/bump-api branch 3 times, most recently from 8e737a4 to 5482c05 Compare September 7, 2018 17:24
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2018
@juanvallejo
Copy link
Contributor Author

@deads2k

has the content here changed again?

No. I have amended the commit message, and removed all of the pinned deps that were added to the glide.yaml file by the depcheck pin command

@juanvallejo
Copy link
Contributor Author

/retest

@deads2k deads2k added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2018
@deads2k deads2k mentioned this pull request Sep 10, 2018
Closed
@juanvallejo
bump(*):
ec60c99 
  - api: 5ad8479f64f1b60ee9c62ce8ef1fe6638838725e
  - client-go: 431ec9a26e5021f35fa41ee9a89842db9bfdb370
  - service-serving-cert-signer: e6e3e052f4aa60d0630c206d5e7885229ff956d5
  - library-go: release-3.11

Note: ./hack/update-deps.sh has moved the package "github.com/elazarl/goproxy"
from the "testImports" section to the "imports" section in the glide.lock file.
Its version hash "c4fc26588b6ef8af07a191fcb6476387bdd46711" remains unchanged.
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2018
@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install

@deads2k
Copy link
Contributor

deads2k commented Sep 11, 2018

confirmed it works

/lgtm
/hold cancel

@juanvallejo your steps look off. You pin before you update. right?

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 11, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@juanvallejo
Copy link
Contributor Author

@deads2k

your steps look off. You pin before you update. right?

Yes, here's what my glide.yaml file looks like before I run ./hack/update-deps.sh: https://gist.github.com/juanvallejo/2edacdfb3cb152024753ad71660cbd95

@juanvallejo
Copy link
Contributor Author

/retest

@juanvallejo
Copy link
Contributor Author

/test gcp

@juanvallejo
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit a3024f8 into openshift:release-3.11 Sep 11, 2018
@juanvallejo juanvallejo deleted the jvallejo/bump-api branch September 12, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@soltysh soltysh Awaiting requested review from soltysh

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanvallejo @deads2k @openshift-ci-robot @openshift-merge-robot