[3.10] migrate: ignore resources that cannot be listed and updated #21083
Conversation
This change updates FindAllCanonicalResources to check the verbs asserted by discovery for listing and updating capability. This prevents us from trying to update aggregated resources such as pod metrics. Bug 1631517 Signed-off-by: Monis Khan <[email protected]> Note: this is a minimal cherrypick since the CLI code has changed a lot during the last few releases.
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherrypick release-3.9 |
|
@enj: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
enj
changed the title
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@enj I think you need to post those against ose not here. The same applies to the 3.9 cherry-pick. |
Yeah I just like to use the origin CI to vet stuff (but the 3.10 unit tests seem to be flaking :/) |
…21083-upstream-ose-enterprise-3.10 Automated cherry pick of openshift#21083 on enterprise-3.10
This change updates FindAllCanonicalResources to check the verbs
asserted by discovery for listing and updating capability. This
prevents us from trying to update aggregated resources such as pod
metrics.
Bug 1631517
Signed-off-by: Monis Khan [email protected]
Note: this is a minimal cherrypick since the CLI code has changed a
lot during the last few releases.
xref: #21071