Add basic auth password authenticator #296
Conversation
liggitt
changed the title
| @@ -0,0 +1,76 @@ | |||
| package basicauthpassword | |||
There was a problem hiding this comment.
this name is pretty ugly ;-) how about moving this into:
pkg/auth/authenticator/basic/password.go
There was a problem hiding this comment.
It's consistent with the other authenticators, which are split finely rather than coarsely.
There was a problem hiding this comment.
@smarterclayton are you agreeing with @mfojtik or with how I did it?
There was a problem hiding this comment.
With you given existing packages
On Oct 30, 2014, at 2:47 PM, Jordan Liggitt [email protected] wrote:
In pkg/auth/authenticator/basicauthpassword/basicauthpassword.go:
@@ -0,0 +1,76 @@
+package basicauthpassword
@smarterclayton are you agreeing with @mfojtik or with how I did it?—
Reply to this email directly or view it on GitHub.
liggitt
changed the title
|
Few nits |
|
@smarterclayton ready to merge |
| Error string | ||
| } | ||
|
|
||
| func New(URL string) *Authenticator { |
There was a problem hiding this comment.
No Godoc and this should be url
|
LGTM [merge] |
|
Origin Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/303/) (Image: devenv-fedora_312) |
Add test for redirect preserving then param
|
rerere[merge] |
|
[Test]ing while waiting on the merge queue |
|
Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/343/) |
|
Evaluated for origin up to b1513a6 |
|
Typo
|
Add more HostSubnet logging
Automatic commit of package [atomic-openshift] release [3.2.1.6].
* implement binding -> broker traversal * adding boilerplate headers * remove mispelling * fix typos * update copyright date
No description provided.