Skip to content

OCPEDGE-1678: Fix failed etcd test on arbiter ci run #29694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

OCPEDGE-1678: Fix failed etcd test on arbiter ci run #29694

merged 1 commit into from
May 14, 2025

Conversation

Neilhamza
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 20, 2025 •
edited by openshift-ci bot
Loading

@Neilhamza: This pull request references OCPEDGE-1678 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Neilhamza
Copy link
Contributor Author

/test e2e-metal-ovn-two-node-arbiter

@openshift-ci openshift-ci bot requested review from Elbehery and hasbro17 April 20, 2025 10:24
@openshift-trt openshift-trt
Copy link

openshift-trt bot commented May 2, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: abc27eb

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial High - "Find all of the input images from ocp/4.20 and tag them into the stable stream" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial High - "Find all of the input images from ocp/4.20 and tag them into the stable-initial stream" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: abc27eb

  • "Find all of the input images from ocp/4.20 and tag them into the stable stream" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "Find all of the input images from ocp/4.20 and tag them into the stable-initial stream" [Total: 2, Pass: 2, Fail: 0, Flake: 0]

@eggfoobar
Copy link
Contributor

/lgtm

@dusk125 I'm not sure if you think we should rename the test from master nodes to control plane nodes to better capture this test, we'll just need to update the test name mapping to make sure we don't loose historical data if we go that route, what do you think?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@dusk125
Copy link
Contributor

dusk125 commented May 8, 2025

@eggfoobar

I'm not sure if you think we should rename the test from master nodes to control plane nodes to better capture this test, we'll just need to update the test name mapping to make sure we don't loose historical data if we go that route, what do you think?

Should be fine, could do it in another PR though I think.

@eggfoobar
Copy link
Contributor

@dusk125 Sounds good, thanks! Then I think we're good with this PR if you want to approve it

@dusk125
Copy link
Contributor

dusk125 commented May 8, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, eggfoobar, Neilhamza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fa5164c and 2 for PR HEAD abc27eb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 590f8e9 and 2 for PR HEAD abc27eb in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 590f8e9 and 2 for PR HEAD abc27eb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 73ca29c and 1 for PR HEAD abc27eb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5c4033e and 2 for PR HEAD abc27eb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 476ee38 and 1 for PR HEAD abc27eb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6724a84 and 0 for PR HEAD abc27eb in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 11, 2025 •
edited
Loading

@Neilhamza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi abc27eb link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-etcd-scaling abc27eb link false /test e2e-aws-ovn-etcd-scaling
ci/prow/okd-e2e-gcp abc27eb link false /test okd-e2e-gcp
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback abc27eb link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-gcp-fips-serial abc27eb link false /test e2e-gcp-fips-serial
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-techpreview abc27eb link false /test e2e-metal-ipi-ovn-dualstack-bgp-techpreview
ci/prow/e2e-aws-ovn-single-node-upgrade abc27eb link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-proxy abc27eb link false /test e2e-aws-proxy
ci/prow/e2e-vsphere-ovn-etcd-scaling abc27eb link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-cgroupsv2 abc27eb link false /test e2e-aws-ovn-cgroupsv2
ci/prow/okd-scos-e2e-aws-ovn abc27eb link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 abc27eb link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-metal-ipi-serial abc27eb link false /test e2e-metal-ipi-serial
ci/prow/e2e-aws abc27eb link false /test e2e-aws
ci/prow/e2e-aws-ovn-single-node abc27eb link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-disruptive abc27eb link false /test e2e-gcp-disruptive
ci/prow/e2e-aws-ovn-upgrade abc27eb link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-etcd-scaling abc27eb link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive abc27eb link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-single-node-serial abc27eb link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-azure abc27eb link false /test e2e-azure
ci/prow/e2e-aws-ovn abc27eb link false /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-kube-apiserver-rollout abc27eb link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-azure-ovn-etcd-scaling abc27eb link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview abc27eb link false /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview
ci/prow/e2e-metal-ovn-two-node-arbiter abc27eb link false /test e2e-metal-ovn-two-node-arbiter
ci/prow/e2e-openstack-serial abc27eb link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn-serial abc27eb link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision abc27eb was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2025
@Neilhamza
Copy link
Contributor Author

/retest-required
/unhold
retesting and removing holds, failures are not related to test

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3bfea73 into openshift:main May 14, 2025
31 of 58 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202505151012.p0.g3bfea73.assembly.stream.el9.
All builds following this will include this PR.

@eggfoobar
Copy link
Contributor

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@eggfoobar: new pull request created: #29826

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elbehery Elbehery Awaiting requested review from Elbehery

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@eggfoobar eggfoobar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Neilhamza @openshift-ci-robot @eggfoobar @dusk125 @openshift-bot @openshift-cherrypick-robot