-
Notifications
You must be signed in to change notification settings - Fork 4.7k
OCPBUGS-55211: use regular user to create httproute #29697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: lihongan. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
gateway := &gatewayapiv1.Gateway{} | ||
|
||
waitErr := wait.PollUntilContextTimeout(context.Background(), 2*time.Second, 10*time.Minute, false, func(context context.Context) (bool, error) { | ||
gateway, errGwStatus := gwapiClient.GatewayV1().Gateways(ingressNameSpace).Get(context, gwname, metav1.GetOptions{}) | ||
if errGwStatus != nil { | ||
gateway, err = oc.AdminGatewayApiClient().GatewayV1().Gateways(ingressNameSpace).Get(context, gwname, metav1.GetOptions{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not use :=
here, otherwise the gateway.Name
is empty in logs as below
I0422 15:27:59.859132 34018 gatewayapicontroller.go:352] Gateway "" successfully programmed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melvinjoseph86 please check your enhancement PR, not sure why you revert the fix.
} | ||
e2e.Logf("Gateway %q successfully programmed!", gateway.Name) | ||
return gateway, nil | ||
} | ||
|
||
// buildGateway initializes the Gateway and returns its address. | ||
func buildGateway(name, namespace, gcname, fromNs, domain string) *gatewayapiv1.Gateway { | ||
hostname := gatewayapiv1.Hostname("*." + "gwapi." + domain) | ||
hostname := gatewayapiv1.Hostname("*." + domain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needn't to insert gwapi.
to the hostname, otherwise it looks like
spec:
gatewayClassName: openshift-default
listeners:
- allowedRoutes:
namespaces:
from: All
hostname: '*.gwapi.gw-default.ci-ln-3if6zbk-72292.origin-ci-int-gce.dev.rhcloud.com'
Indeed, we replace apps.
to gw-xxx.
in the test to generate the domain for gateway.
/test e2e-gcp-ovn-techpreview |
/test e2e-gcp-ovn-techpreview |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc-techpreview |
@lihongan: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3987ae80-1ff4-11f0-87b0-4cf6a73fa7bb-0 |
|
||
g.By("Create the http route using the custom gateway") | ||
httproutes = append(httproutes, "test-httproute") | ||
defaultRoutename := "test-hostname.gwapi." + customDomain | ||
defaultRoutename := "test-hostname." + customDomain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the gwapi.
to match the change in func buildGateway()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a couple of nit picks. Do you plan to hold the merge of this PR until openshift/api#2284 is merged?
/test e2e-gcp-ovn-techpreview |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview |
@lihongan: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2f84f70-20e6-11f0-85b1-f4e8960d0d92-0 |
Job Failure Risk Analysis for sha: 7c59634
|
/test e2e-gcp-ovn-techpreview |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview |
@lihongan: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea8a8580-2112-11f0-95a4-05dc2bf9eef1-0 |
/retest-required |
@lihongan: An error was encountered searching for bug OCPBUGS-55211 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-55211": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-55211 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Job Failure Risk Analysis for sha: aaa81c0
|
Job Failure Risk Analysis for sha: aaa81c0
|
/retest-required |
/lgtm |
Job Failure Risk Analysis for sha: aaa81c0
|
/retest-required two required jobs failed due to timed out
|
Job Failure Risk Analysis for sha: aaa81c0
|
Aah, In the initial commit I'd like to skip 2 tests on Metal and enable other 3 tests on Metal, but I also found the issues you liked here, so finally I reverted the change and keep the original way (skip all 5 tests on Metal). |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview |
@lihongan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed4c0340-3128-11f0-9e08-89d9ff694833-0 |
Job Failure Risk Analysis for sha: aaa81c0
|
@xueqzhan rerun the job and the latest one is green https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/openshift-origin-29697-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, lihongan, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lihongan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
d03198f
into
openshift:main
@lihongan: Jira Issue OCPBUGS-55211: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55211 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
enhancement for httproute test