Skip to content

[release-4.19] OCPBUGS-56213: Skip GatewayAPIController tests on clusters without OLM capabilities #29815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] OCPBUGS-56213: Skip GatewayAPIController tests on clusters without OLM capabilities #29815

wants to merge 2 commits into from

Conversation

alebedev87
Copy link
Contributor

This is a manual cherry pick of #29784.

alebedev87 added 2 commits May 18, 2025 21:28
@alebedev87
Add test helpers to check if cluster capabilities are enabled and ski…
8cd52ac 
…p accordingly
@alebedev87
OCPBUGS-55317: Skip GatewayAPIController tests on clusters without OL…
e521925 
…M capabilities

This ensures GatewayAPIController tests are only run on clusters
where OLM and related capabilities are enabled.
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 18, 2025
@openshift-ci-robot
Copy link

@alebedev87: This pull request references Jira Issue OCPBUGS-56213, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry pick of #29784.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 18, 2025
@openshift-ci openshift-ci bot requested review from deads2k and miheer May 18, 2025 19:30
@alebedev87
Copy link
Contributor Author

/retest

@alebedev87
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-no-capabilities

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@alebedev87: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-no-capabilities

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7fa7b8e0-347d-11f0-8d3a-84c24e490c0a-0

@alebedev87
Copy link
Contributor Author

Analysis of the payload test with no capabilities:

  • GatewayAPIController tests were skipped as expected:
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/openshift-origin-29815-ci-4.19-e2e-aws-ovn-no-capabilities/1924356890825854976/artifacts/e2e-aws-ovn-no-capabilities/openshift-e2e-test/build-log.txt | grep GatewayAPIController
started: 3/75/431 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure HTTPRoute object is created [Suite:openshift/conformance/parallel]"
skipped: (1.1s) 2025-05-19T08:41:00 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure HTTPRoute object is created [Suite:openshift/conformance/parallel]"
started: 3/79/431 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure LB, service, and dnsRecord are created for a Gateway object [Suite:openshift/conformance/parallel]"
skipped: (1.2s) 2025-05-19T08:41:02 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure LB, service, and dnsRecord are created for a Gateway object [Suite:openshift/conformance/parallel]"
started: 4/130/431 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure OSSM and OLM related resources are created after creating GatewayClass [Suite:openshift/conformance/parallel]"
skipped: (1.1s) 2025-05-19T08:41:36 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure OSSM and OLM related resources are created after creating GatewayClass [Suite:openshift/conformance/parallel]"
started: 7/185/431 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure custom gatewayclass can be accepted [Suite:openshift/conformance/parallel]"
skipped: (1.1s) 2025-05-19T08:42:17 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure custom gatewayclass can be accepted [Suite:openshift/conformance/parallel]"
started: 20/304/431 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure default gatewayclass is accepted [Suite:openshift/conformance/parallel]"
skipped: (1s) 2025-05-19T08:45:41 "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure default gatewayclass is accepted [Suite:openshift/conformance/parallel]"
  • GatewayAPI tests passed:
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/openshift-origin-29815-ci-4.19-e2e-aws-ovn-no-capabilities/1924356890825854976/artifacts/e2e-aws-ovn-no-capabilities/openshift-e2e-test/build-log.txt | grep -w GatewayAPI
started: 3/63/431 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure required CRDs should already be installed [Suite:openshift/conformance/parallel]"
passed: (1.5s) 2025-05-19T08:40:55 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure required CRDs should already be installed [Suite:openshift/conformance/parallel]"
started: 10/206/431 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group is not installed [Suite:openshift/conformance/parallel]"
passed: (1.5s) 2025-05-19T08:42:34 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group is not installed [Suite:openshift/conformance/parallel]"
started: 14/263/431 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of standard group can not be created [Suite:openshift/conformance/parallel]"
passed: (1.4s) 2025-05-19T08:43:49 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of standard group can not be created [Suite:openshift/conformance/parallel]"
started: 30/373/431 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group can not be created [Suite:openshift/conformance/parallel]"
passed: (1.8s) 2025-05-19T08:46:48 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group can not be created [Suite:openshift/conformance/parallel]"
started: 35/408/431 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be updated [Suite:openshift/conformance/parallel]"
passed: (1.9s) 2025-05-19T08:47:06 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be updated [Suite:openshift/conformance/parallel]"
started: 36/424/431 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be deleted [Suite:openshift/conformance/parallel]"
passed: (1.6s) 2025-05-19T08:47:18 "[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be deleted [Suite:openshift/conformance/parallel]"

@alebedev87
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@alebedev87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kube-apiserver-rollout e521925 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-serial e521925 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade e521925 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knobunc knobunc added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2025
@knobunc
Copy link
Contributor

knobunc commented May 19, 2025

/approve

@lihongan
Copy link
Contributor

/label qe-approved
/label cherry-pick-approved

based on the analysis of the payload test

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 20, 2025
@openshift-ci-robot
Copy link

@alebedev87: This pull request references Jira Issue OCPBUGS-56213, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

This is a manual cherry pick of #29784.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@lihongan: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label qe-approved
/label cherry-pick-approved

based on the analysis of the payload test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Miciah
Copy link
Contributor

Miciah commented May 20, 2025

/lgtm

I cannot add the "backport-risk-assessed" label. However, my assessment is that this is a low-risk change that only modifies the E2E test to add a skip for an unsupported configuration.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alebedev87, knobunc, Miciah
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alebedev87
Copy link
Contributor Author

/assign @deads2k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@miheer miheer Awaiting requested review from miheer

Assignees

@Miciah Miciah

@deads2k deads2k

Labels
jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alebedev87 @openshift-ci-robot @knobunc @lihongan @Miciah @deads2k