Skip to content

NO-JIRA: We should always run tests where we have no opinion on their gate #29828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/clioptions/suiteselection/feature_filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ func (f *featureGateFilter) includeTest(name string) bool {
return false
}

return f.enabled.HasAll(featureGates...)
// It is important that we always return true if we don't know the status of the gate.
// This generally means we have no opinion on whether the feature is on or off.
// We expect the default case to be on, as this is what would happen after a feature is promoted,
// and the gate is removed.
return true
}

func includeNonFeatureGateTest(name string) bool {
Expand Down