Skip to content

OCPBUGS-56512: updates ruby to version 3.3 #29832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rhdmalone
Copy link

@rhdmalone rhdmalone commented May 21, 2025

updates Ruby version to 3.3
Note 1: If you have modified test/extended/cli/setimage.go do the following in the origin folder in a terminal:
make update-gofmt
You may see that the file will have been updated. If so, git add etc

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial May 21, 2025 09:15
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhdmalone
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhdmalone rhdmalone changed the title test comment to see if tests pass in PR OCPBUGS-56512: updates ruby to version 3.3 May 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 21, 2025
@openshift-ci-robot
Copy link

@rhdmalone: This pull request references Jira Issue OCPBUGS-56512, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@rhdmalone: This pull request references Jira Issue OCPBUGS-56512, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Added a test comment to see if tests in PR pass initially before any changes are made

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhdmalone
Copy link
Author

/retest

@rhdmalone
Copy link
Author

label /retest

@rhdmalone
Copy link
Author

/retest-required

@rhdmalone
Copy link
Author

/test verify

2 similar comments
@rhdmalone
Copy link
Author

/test verify

@rhdmalone
Copy link
Author

/test verify

Copy link
Contributor

openshift-ci bot commented May 22, 2025

@rhdmalone: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet-2of2 e15c5bc link false /test e2e-aws-ovn-serial-publicnet-2of2
ci/prow/e2e-gcp-fips-serial-2of2 e15c5bc link false /test e2e-gcp-fips-serial-2of2
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback e15c5bc link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-aws-disruptive e15c5bc link false /test e2e-aws-disruptive
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 e15c5bc link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-ovn-image-ecosystem e15c5bc link true /test e2e-gcp-ovn-image-ecosystem
ci/prow/okd-e2e-gcp e15c5bc link false /test okd-e2e-gcp
ci/prow/e2e-gcp-ovn-etcd-scaling e15c5bc link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling e15c5bc link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-builds e15c5bc link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 e15c5bc link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-aws-ovn-etcd-scaling e15c5bc link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling e15c5bc link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-upgrade e15c5bc link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade e15c5bc link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-fips-serial-1of2 e15c5bc link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-hypershift-conformance e15c5bc link false /test e2e-hypershift-conformance
ci/prow/e2e-gcp-disruptive e15c5bc link false /test e2e-gcp-disruptive
ci/prow/e2e-openstack-ovn e15c5bc link false /test e2e-openstack-ovn
ci/prow/e2e-openstack-serial e15c5bc link false /test e2e-openstack-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented May 22, 2025

Job Failure Risk Analysis for sha: e15c5bc

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback MissingData
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 50.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (28) are below the historical average (3890): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants