Skip to content

OCPBUGS-35855: Add dry-run server test for imagestreamtag #29834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-35855: Add dry-run server test for imagestreamtag #29834

wants to merge 1 commit into from

Conversation

ardaguclu
Copy link
Member

This PR adds a simple test to ensure that dry-run option is taken account by image api server.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 21, 2025
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-35855, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR adds a simple test to ensure that dry-run option is taken account by image api server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 May 21, 2025 11:34
@ardaguclu
Copy link
Member Author

This test should fail without openshift/openshift-apiserver#511
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2025
@openshift-ci openshift-ci bot requested review from ironcladlou and p0lyn0mial May 21, 2025 11:35
@ardaguclu
Copy link
Member Author

Without the patch in openshift-apiserver, https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29834/pull-ci-openshift-origin-main-e2e-aws-ovn-image-registry/1925162064351858688 failed as expected.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2025

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp 35cbae5 link false /test okd-e2e-gcp
ci/prow/e2e-aws-ovn-serial-2of2 35cbae5 link true /test e2e-aws-ovn-serial-2of2
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 35cbae5 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-gcp-ovn 35cbae5 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 35cbae5 link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-metal-ipi-serial-2of2 35cbae5 link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-azure-ovn-etcd-scaling 35cbae5 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling 35cbae5 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling 35cbae5 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive 35cbae5 link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-ovn-upgrade 35cbae5 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 35cbae5 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-fips-serial-2of2 35cbae5 link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-gcp-fips-serial-1of2 35cbae5 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-aws-ovn-etcd-scaling 35cbae5 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-csi 35cbae5 link false /test e2e-gcp-csi
ci/prow/e2e-aws-disruptive 35cbae5 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-serial-publicnet-2of2 35cbae5 link false /test e2e-aws-ovn-serial-publicnet-2of2
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 35cbae5 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-image-registry 35cbae5 link true /test e2e-aws-ovn-image-registry
ci/prow/e2e-openstack-serial 35cbae5 link false /test e2e-openstack-serial
ci/prow/e2e-gcp-ovn-rt-upgrade 35cbae5 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-azure-ovn-upgrade 35cbae5 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 35cbae5 link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangke19 wangke19 Awaiting requested review from wangke19

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@flavianmissi flavianmissi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardaguclu @openshift-ci-robot @flavianmissi