Skip to content

OCPQE-29454: labelcompare #29839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPQE-29454: labelcompare #29839

wants to merge 1 commit into from

Conversation

huali9
Copy link

@huali9 huali9 commented May 22, 2025

passed in local @JoelSpeed @sunzhaohua2 @miyadav @shellyyang1989 PTAL, thanks!

  Will run 1 of 1 specs
  ------------------------------
  [sig-cluster-lifecycle][Feature:Machines] Managed cluster should the Machine provider spec zone should match the label on the paired node
  github.com/openshift/origin/test/extended/machines/machines.go:119
    STEP: Creating a kubernetes client @ 05/22/25 17:29:53.816
  I0522 17:29:53.819079    6382 discovery.go:214] Invalidating discovery information
    STEP: Listing all Machines ... @ 05/22/25 17:29:54.114
  I0522 17:29:54.686744 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-20-69.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
  I0522 17:29:56.306668 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-39-58.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
  I0522 17:29:57.594502 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-80-165.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
  I0522 17:29:58.891679 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-6-87.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
  I0522 17:30:00.156501 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-43-182.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
  I0522 17:30:01.361538 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-85-255.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
  • [8.774 seconds]
  ------------------------------

  Ran 1 of 1 Specs in 8.775 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@huali9: This pull request references OCPQE-29454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

passed in local @JoelSpeed @sunzhaohua2 @miyadav @shellyyang1989 PTAL, thanks!

 Will run 1 of 1 specs
 ------------------------------
 [sig-cluster-lifecycle][Feature:Machines] Managed cluster should the Machine provider spec zone should match the label on the paired node
 github.com/openshift/origin/test/extended/machines/machines.go:119
   STEP: Creating a kubernetes client @ 05/22/25 17:29:53.816
 I0522 17:29:53.819079    6382 discovery.go:214] Invalidating discovery information
   STEP: Listing all Machines ... @ 05/22/25 17:29:54.114
 I0522 17:29:54.686744 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-20-69.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
 I0522 17:29:56.306668 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-39-58.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
 I0522 17:29:57.594502 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-80-165.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
 I0522 17:29:58.891679 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-6-87.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
 I0522 17:30:00.156501 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-43-182.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
 I0522 17:30:01.361538 6382 client.go:952] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig2 get node ip-10-0-85-255.us-east-2.compute.internal -o=jsonpath={.metadata.labels.topology\.kubernetes\.io\/zone}'
 • [8.774 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 8.775 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ingvagabund and sjenning May 22, 2025 09:51
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huali9
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2025

@huali9: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 f537afb link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-gcp-ovn-etcd-scaling f537afb link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive f537afb link false /test e2e-aws-disruptive
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 f537afb link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-ovn-rt-upgrade f537afb link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-openstack-serial f537afb link false /test e2e-openstack-serial
ci/prow/e2e-gcp-fips-serial-2of2 f537afb link false /test e2e-gcp-fips-serial-2of2
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback f537afb link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-vsphere-ovn-etcd-scaling f537afb link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 f537afb link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-gcp-disruptive f537afb link false /test e2e-gcp-disruptive
ci/prow/e2e-hypershift-conformance f537afb link false /test e2e-hypershift-conformance
ci/prow/e2e-gcp-ovn f537afb link true /test e2e-gcp-ovn
ci/prow/okd-e2e-gcp f537afb link false /test okd-e2e-gcp
ci/prow/e2e-gcp-ovn-upgrade f537afb link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-etcd-scaling f537afb link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-edge-zones f537afb link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-azure-ovn-etcd-scaling f537afb link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-csi f537afb link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented May 22, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: f537afb

  • "[sig-cluster-lifecycle][Feature:Machines] Managed cluster should the Machine provider spec zone should match the label on the paired node [Suite:openshift/conformance/parallel]" [Total: 9, Pass: 9, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@sjenning sjenning Awaiting requested review from sjenning

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huali9 @openshift-ci-robot