Skip to content

add option to reverse buildchains #8460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2016
Merged

add option to reverse buildchains #8460

merged 1 commit into from
Apr 26, 2016

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 11, 2016

This allows a user to start with an istag and find all the builds and images that lead to it.

oc process -f examples/sample-app/application-template-stibuild.json -l build=sti | oc create -f -
[deads@deads-dev-01 origin]$ oadm build-chain istag/origin-ruby-sample --reverse
istag/origin-ruby-sample:latest
    bc/ruby-sample-build
        istag/ruby-22-centos7:latest

@bparees @Kargakis

@bparees
Copy link
Contributor

bparees commented Apr 11, 2016

how does the output handle forking?

bparees
bparees reviewed Apr 11, 2016
View reviewed changes
pkg/cmd/cli/describe/chaindescriber.go
edgeFn := osgraph.EdgesOfKind(edgeKinds...)
sub := g.Subgraph(nodeFn, edgeFn)

// Filter out inbound edges to the ist of interest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list(?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list(?)

ist. imagestreamtag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IST then. (yeah it's nit picky, but it confused me, so....)

@bparees
Copy link
Contributor

bparees commented Apr 11, 2016

wouldn't mind a test case...

@deads2k
Copy link
Contributor Author

deads2k commented Apr 11, 2016

wouldn't mind a test case...

Sure. When I need a break from the rebase I'll write up with some forks to deal with both comments.

@0xmichalis
Copy link
Contributor

lgtm

@deads2k
Copy link
Contributor Author

deads2k commented Apr 19, 2016

how does the output handle forking?

Test added. Output:

[deads@deads-dev-01 origin]$ oadm build-chain istag/child2img:latest --reverse
istag/child2img:latest
    bc/child2
        istag/parent1img:latest
            bc/parent1
                istag/ruby-22-centos7:latest
        istag/parent3img:latest
            bc/parent3
                istag/ruby-22-centos7:latest

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2016
@deads2k
Copy link
Contributor Author

deads2k commented Apr 26, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 26, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3279/) (Image: devenv-rhel7_4039)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 1e65fd2

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 1e65fd2

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3279/)

@openshift-bot openshift-bot merged commit a5a4ec5 into openshift:master Apr 26, 2016
@deads2k deads2k deleted the fix-build-chains branch September 6, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @bparees @0xmichalis @openshift-bot