Disable UI scaling for in progress deployment #8761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -166,6 +166,8 @@ angular.module('openshiftConsole') | |||
| } | |||
|
|
|||
| $scope.deployments = LabelFilter.getLabelSelector().select($scope.unfilteredDeployments); | |||
| $scope.deploymentInProgress = _.size($scope.deploymentConfigDeploymentsInProgress[deploymentConfigName]); | |||
There was a problem hiding this comment.
since you are treating this as a boolean can you !! it
|
just the one comment otherwise LGTM |
spadgett
force-pushed
the
disable-scaling-in-flight-deployment
branch
from
9d6a91d to
866661a
Compare
|
Updated. Thanks @jwforres [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5831/) (Image: devenv-rhel7_4122) |
|
[Test]ing while waiting on the merge queue |
|
👍 |
openshift-bot
added
the
needs-rebase
spadgett
force-pushed
the
disable-scaling-in-flight-deployment
branch
from
866661a to
d4756e3
Compare
|
Rebased [merge] |
spadgett
force-pushed
the
disable-scaling-in-flight-deployment
branch
from
d4756e3 to
f168410
Compare
openshift-bot
removed
the
needs-rebase
|
Evaluated for origin test up to f168410 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3634/) |
|
Evaluated for origin merge up to f168410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1333129
@jwforres PTAL
@csrwng @Kargakis CC