allow project request limits on system users and service accounts #8766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,15 @@ import ( | |||
| type ProjectRequestLimitConfig struct { | |||
| unversioned.TypeMeta | |||
| Limits []ProjectLimitBySelector | |||
|
|
|||
| // MaxProjectsForSystemUsers controls how many projects a cert user may have. Certificate | |||
|
really minor nit and it looks like you need to regenerate docs. Other than that, LGTM |
deads2k
force-pushed
the
project-request-limit
branch
from
da056d8 to
4142134
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5833/) (Image: devenv-rhel7_4124) |
|
Evaluated for origin merge up to 4142134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1333049
Adds the ability to limit the number of projects that a cert user can have and prevents the forbidden error.
@csrwng ptal
@stenwt @a13m fyi