Provide descriptions #8807
Provide descriptions #8807
Conversation
| func (userEvaluator) Describe(scope string) string { | ||
| switch scope { | ||
| case UserIndicator + UserInfo: | ||
| return "information about you, including username, identity names, and group membership" |
There was a problem hiding this comment.
If this information is going to be returned to a user, should it be properly capitalized and punctuated?
Also, grammar-nit; needs a colon (but I agree on the use of the Oxford Comma):
"Information about you, including: username, identity names, and group membership."
There was a problem hiding this comment.
If this information is going to be returned to a user, should it be properly capitalized and punctuated?
Also, grammar-nit; needs a colon (but I agree on the use of the Oxford Comma):
"Information about you, including: username, identity names, and group membership."
@jwforres @fabianofranz I think that @liggitt's intent is for this to be a human readable string you can present to a user to describe a scope. I don't know precisely how he intends for you to get the information in the console, but in the CLI this is pretty easy to get. Should it be a complete sentence?
|
Modulo the specific string contents under discussion, LGTM. |
deads2k
force-pushed
the
provide-descriptions
branch
from
ef92ced to
6227848
Compare
Updated strings. We can always change our mind later. [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5864/) (Image: devenv-rhel7_4152) |
deads2k
force-pushed
the
provide-descriptions
branch
from
6227848 to
3b0ec27
Compare
|
Evaluated for origin merge up to 3b0ec27 |
Add human readable descriptions for scopes.
@sgallagher last commit only.