Skip to content

Prevent route theft by removing the ability to update spec.host #9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

smarterclayton
Copy link
Contributor

Once created, spec.host is immutable. This preserves the ordering of
route creation which makes route ordering safe.

This rolls back the "on update" allocation of spec.host, since that
complicates allocation.

A route with an empty spec.host may be defaulted by the caller (it means
they don't care) - clients should be looking at route.status anyway.

Fixes BZ1328625

@ramr @pweil-

[test]

Once created, spec.host is immutable. This preserves the ordering of
route creation which makes route ordering safe.

This rolls back the "on update" allocation of spec.host, since that
complicates allocation.

A route with an empty spec.host may be defaulted by the caller (it means
they don't care) - clients should be looking at route.status anyway.
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9595389

@pweil-
Copy link

pweil- commented Jun 14, 2016

LGTM

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4835/)

@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4835/) (Image: devenv-rhel7_4373)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 9595389

@openshift-bot openshift-bot merged commit f574e94 into openshift:master Jun 14, 2016
@tachikawascholarly
Copy link

The way to prevent route theft from happening is by enforcing encryption on top of unsecured social media where private credentials are submitted and implement a security defence system (anti-spyware program) on everyone's computer that would prevent access by remote cyber thieves blocking off all accessible entries obtainable over the internet

This should eliminate all threats posed by spyware a cyber thief would not be able to obtain any private info The defence system would target any malicious and suspicious hacker or software trying to access the person's computer. In this prevention of route theft software the person or social media responsible for planting this spying software would be traced from anywhere in the world and their I.P (internet protocol) which is assigned specifically to each individual computer or server in the world could be traced and prosecuted which finally put an end to identity route theft on the internet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants