extended: refactor deployment test to be more debuggable #9686
Conversation
|
[testextended][extended:core(iteratively)] |
| err = wait.PollImmediate(500*time.Millisecond, 10*time.Second, condition) | ||
| printDebugInfo(err, oc, name) |
There was a problem hiding this comment.
Instead of needing printDebugInfo, why not have the condition include this info in the error? Or have the failure trap print it out? both of those are more readable and easier to reuse.
There was a problem hiding this comment.
I cannot see the debug info from the failure trap on the test above working, probably because the test is not returning but the test framework exits without running the defer? We probably need an AfterEach handler.
0xmichalis
changed the title
|
@smarterclayton I've verified that the failure trap now works, PTAL |
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
|
|
||
| g.By(fmt.Sprintf("by checking that the first deployer was deleted and the second deployer exists")) | ||
| condition = func() (bool, error) { |
There was a problem hiding this comment.
this looks better embedded in the wait function (same as above)
|
Evaluated for origin testextended up to 72387fa |
|
Lgtm [merge] |
|
Evaluated for origin merge up to 72387fa |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/287/) (Extended Tests: core(iteratively)) |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 72387fa |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5814/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5817/) |
Will help in debugging #9681
@smarterclayton