Fix required parameters for multiple templates #9741
Closed
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several parameters that are required during the build process. However, those are not marked as required which will cause failure if users leave them blank. Those parameters need to be explicitly marked as required to avoid confusion and unexpected failure. Signed-off-by: Vu Dinh <[email protected]>
|
it looks like you're updating these manually. use the script mentioned in the readme. and you'll need to run hack/gen-bootstrap-bindata.sh |
|
Close this PR as it's no longer needed. PR #9754 contains the changes from this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several parameters that are required during the build process.
However, those are not marked as required which will cause failure if
users leave them blank. Those parameters need to be explicitly marked as
required to avoid confusion and unexpected failure.
Signed-off-by: Vu Dinh [email protected]