Skip to content

CORENET-5389,OCPBUGS-51040,OCPBUGS-54577: [DownstreamMerge] 2025-04-16 #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Apr 22, 2025

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Apr 16, 2025

πŸ“‘ Description

This D/S sync brings along primary UDN for virtualization fixes for IPv6.

Fixes #

Additional Information for reviewers

Clean merge, no conflicts.

βœ… Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

martinkennelly and others added 24 commits March 24, 2025 19:20
The option "ovn-openflow-probe-interval" is ignored from ovn24.03.
Replace it with "ovn-bridge-remote-probe-interval" which serves
similar purpose with the difference that from 24.09 it affects all
connections to br-int, not only the main thread.

At the same time change the default to 0 which is disabled, the
inactivity probe shouldn't be needed for connections over unix
socket.

Signed-off-by: Ales Musil <[email protected]>
Extend the ClusterUserDefinedNetwork (CUDN) spec to enable
creating Localnet topology networks.

Adjusting the NetworkTopology enum validation and enum validation on
the topology Role to fit UDN and CUDN CRDs will be done in follow-up commit.

Signed-off-by: Or Mergi <[email protected]>
Localnet topology should be available for CUDN only.
Move the NetworkTopology enum validation from shard.go to
each definition that use NetworkTopology, having:
- UserDefineNetwork CRD spec.topology accepts:
  Layer2 and Layer3.
- ClusterUserDefineNetwork CRD spec.network.topology accepts:
  Layer2, Layer3 and Localnet.

Signed-off-by: Or Mergi <[email protected]>
Localnet topology role should secondary only.
Move the NetworkRole enum validation from shard.go to
each definition that use NetworkRole, having:
- Layer2Config & Layer3Config role field accepts: Secondary and Primary.
- LocalnetConfig role field accepts: Secondary only.

Signed-off-by: Or Mergi <[email protected]>
node, metrics: Replace depracated option with equivalent
htmlmin is no longer working with newer versions of python

Signed-off-by: Jamo Luhrsen <[email protected]>
Ovnkube-identity pods should run on all control-plane nodes and
require that a newly created pod is fully functional before the old
one can be terminated and hence require additional pods during upgrades

Signed-off-by: nithyar <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
We cannot bump to fedora40 until kubevirt v1.5.0 is not used, this is
related to [1]

[1] kubevirt/kubevirt#13458

Signed-off-by: Enrique Llorente <[email protected]>
Convert to DaemonSet and fix update strategy of ovnkube-identity pods
kubevirt, l2, udpn: send unsolicited router advertisement after live migration to reconcile ipv6 default gw
chore: update footer with trademark disclaimer
symlink docs/governance/* to identical files in /
IPv6 Router Advertisements from non-local sources can interfere with primary UDN interfaces
in multi-gateway setups, resulting in multiple default gateways.

To resolve this, ingress filtering was added using nftables to block unwanted RAs,
allowing only RAs from the node's local gateway and RAs with Lifetime 0,
which are needed to invalidate entries during migration.

Signed-off-by: Or Shoval <[email protected]>
At VM startup the default gw should have only one path after the
nftables change at the network namespace

Signed-off-by: Enrique Llorente <[email protected]>
BGP routes will be imported to the UDN VRF and GR, when EgressIP
for the UDN is advertised to the default VRF. This ensures that the
egress traffic can find the right egress route.

Signed-off-by: Peng Liu <[email protected]>
UDN: Filter RA according local GW Router LLA only to avoid multi path
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 16, 2025
@openshift-ci-robot
Copy link
Contributor

@maiqueb: This pull request references Jira Issue OCPBUGS-51040, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

πŸ“‘ Description

This D/S sync brings along primary UDN for virtualization fixes for IPv6.

Fixes #

Additional Information for reviewers

Clean merge, no conflicts.

βœ… Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jcaamano and trozet April 16, 2025 10:32
@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade 10

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@tssurya: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9eb88130-1f72-11f0-98ff-7c88c9a425f8-0

@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

/payload 4.19 nightly blocking

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@tssurya: trigger 11 job(s) of type blocking for the nightly release of OCP 4.19

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c96f9030-1f72-11f0-9a54-6d9a6e20de5c-0

@qinqon
Copy link
Contributor

qinqon commented Apr 22, 2025

/test e2e-aws-ovn-virt

@ormergi
Copy link
Contributor

ormergi commented Apr 22, 2025

Retest following changes has been done on CI to address the issues with AWS lanes openshift/release#64121

/retest-required

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 22, 2025

/test e2e-aws-ovn-virt

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 22, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

/approve
except windows rest are passing so let that get retest-ed as part of merge queue

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, maiqueb, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3b45a03 and 2 for PR HEAD 9a73d1f in total

@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

/tide refresh

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3b45a03 and 2 for PR HEAD 9a73d1f in total

@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

windows is failing with:

 failed to reconcile machineset ci-op-2ttkyjvl-f5adf-ssjp5-e2e, err: failed to unmarshal decoded user-data to json (secret windows-user-data): invalid character '<' looking for beginning of valuet]}

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2516/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-windows/1914747326312747008
some unrelated error from what I can tell

@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

/override ci/prow/e2e-aws-ovn-windows

https://issues.redhat.com/browse/WINC-1384 tracks the cert bug for windows

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@tssurya: Overrode contexts on behalf of tssurya: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows

https://issues.redhat.com/browse/WINC-1384 tracks the cert bug for windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tssurya
Copy link
Contributor

tssurya commented Apr 22, 2025

/tide refresh

@openshift-merge-bot openshift-merge-bot bot merged commit ced1ea7 into openshift:master Apr 22, 2025
37 of 42 checks passed
@openshift-ci-robot
Copy link
Contributor

@maiqueb: Jira Issue OCPBUGS-51040: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-51040 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-54577: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54577 has been moved to the MODIFIED state.

In response to this:

πŸ“‘ Description

This D/S sync brings along primary UDN for virtualization fixes for IPv6.

Fixes #

Additional Information for reviewers

Clean merge, no conflicts.

βœ… Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@maiqueb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-techpreview 9a73d1f link false /test e2e-aws-ovn-single-node-techpreview
ci/prow/security 9a73d1f link false /test security
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview 9a73d1f link false /test e2e-aws-ovn-hypershift-conformance-techpreview
ci/prow/e2e-ovn-hybrid-step-registry 9a73d1f link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-ovn-kubevirt 9a73d1f link false /test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.20.0-202504222310.p0.gced1ea7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.20.0-202504222310.p0.gced1ea7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.20.0-202504222310.p0.gced1ea7.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-04-24-005837

neisw added a commit to neisw/ovn-kubernetes that referenced this pull request May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.