-
Notifications
You must be signed in to change notification settings - Fork 157
[release-4.19] CORENET-5975: Dockerfile: Unpin OVS and consume the latest from FDP. #2548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.19
Are you sure you want to change the base?
Conversation
OVN-Kubernetes is always lagging behind on the version of OVS it pins. This is causing a lot of trouble with keeping up with bug fixes and especially CVE fixes on older branches, resulting in scanners constantly flagging this image with poor security grades. OVS package inside the container is responsible for the following: 1. Command line utilities to talk with OVS from the host. 2. ovsdb-server processes serving OVN databases. 3. ovs-monitor-ipsec script for managing ipsec configuration on OVN tunnels. These tools/programs are not changing that much between patch releases, and bug fix releases in FDP are going through a lot of testing before becoming available in the repo. So, benefits of timely delivery of bug and CVE fixes significantly outweighs the small risks that automatic consumption of new builds incurs. Main OVS is working on the host and follows FDP for a very long time now, and it's also better to keep the minor versions between host and container in sync, just to decrease the amount of variables in the system. Signed-off-by: Ilya Maximets <[email protected]>
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CORENET-5975 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean cherry-pick. 4.19 isn't far from 4.20 yet.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: igsilya, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-ovn-fdp-qe |
/retest |
Some jobs seem to be stuck. |
/retest-required |
/hold I think we want to stop using cherry-pick bots and bring in our code to older branches via 'git merge' |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When is that expected to happen for 4.19? If that doesn't happen before the first RHSAs for ovs 3.5 or ovn24.09 I'll be back to merge this as is. |
This is an automated cherry-pick of #2525
/assign igsilya