Skip to content

[DNM] Ovs cpu part2 saga revert set3 #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[DNM] Ovs cpu part2 saga revert set3 #2560

wants to merge 7 commits into from

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented May 10, 2025 •
edited
Loading

Encap fixes

@openshift-ci openshift-ci bot requested review from jcaamano and trozet May 10, 2025 18:19
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2025
@tssurya tssurya changed the title Ovs cpu part2 saga revert set3 [DNM] Ovs cpu part2 saga revert set3 May 10, 2025
@tssurya
Copy link
Contributor Author

tssurya commented May 10, 2025

looks like commits were not standalone :/ closing this as I can only revert the full feature to get results

@tssurya tssurya closed this May 10, 2025
@tssurya tssurya reopened this May 12, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
crnithya added 5 commits May 12, 2025 09:45
@crnithya @tssurya
OVN IC mode should handle user set encapIPs
dad091e 
Signed-off-by: nithyar <[email protected]>
(cherry picked from commit d1bbbab)
@crnithya @tssurya
Update IC tests for encap records insertion and deletion
eed97cb 
Signed-off-by: nithyar <[email protected]>
(cherry picked from commit 98a016a)
@crnithya @tssurya
Add createorupdatechassis tests
bd08e59 
Signed-off-by: nithyar <[email protected]>
(cherry picked from commit fbe5bea)
@crnithya @tssurya
Enable insertion of encap records to existing chassis
f59898e 
Chassis should handle multiple encaps and they could be added or removed
dynamically. CreateOrUpdateChassis function is programmed to set only the
list of current encaps based on node-encap-ips annotation and stale
entries would be garbage collected.

Signed-off-by: nithyar <[email protected]>
(cherry picked from commit 971d8c9)
@crnithya @tssurya
Remove redundant nodeprimaryaddrchanged check
47f84f7 
Change to node primary IP is already taken into account while setting
effective.encapip and we are tracking changes to node-encap-ips
annotation

Signed-off-by: nithyar <[email protected]>
(cherry picked from commit 508747e)
@tssurya tssurya force-pushed the OVS-CPU-part2-saga-revert-set3 branch from 5bc239d to 47f84f7 Compare May 12, 2025 07:46
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
@tssurya
Copy link
Contributor Author

tssurya commented May 12, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 12, 2025

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade 5bc239d link true /test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade 5bc239d link true /test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tssurya added 2 commits May 12, 2025 09:52
@tssurya
Revert "Add flow for host -> localnet on same node"
90a100e 
This reverts commit 0ee80bf.

Conflict in gateway_shared_intf.go because of not having
https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5153/files#diff-d3aa58d9b58a0a09264f072df46ab01d0501eb508c4656411ae2dc1ac68fb3c4

Signed-off-by: Surya Seetharaman <[email protected]>
(cherry picked from commit ebb7339)
(cherry picked from commit b3760a1)
@tssurya
Revert "e2e: connect to host-networked pod from localnet"
baa5ede 
This reverts commit b1525c3.

Signed-off-by: Surya Seetharaman <[email protected]>
(cherry picked from commit 936e621)
(cherry picked from commit def2909)
@tssurya
Copy link
Contributor Author

tssurya commented May 12, 2025

/payload 4.20 nightly blocking

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 12, 2025

@tssurya: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.20-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f0224660-2f07-11f0-87fe-f4e1b9ac4570-0

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaamano jcaamano Awaiting requested review from jcaamano

@trozet trozet Awaiting requested review from trozet

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tssurya @openshift-merge-robot @crnithya