Skip to content

Add necessary bits for Vexxhost operator cluster profile #30774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Sandeepyadav93
Copy link
Contributor

  • Add the cloud resource names into openstack-conf-resourcenames
  • Add secrets into openstack-conf-clouds
  • Add infos for Bosko
  • Configure quotas for 2 leases (for now)

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

Hi @Sandeepyadav93. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from danilo-gemoli and gryf July 25, 2022 14:42
@bbguimaraes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD d131d1c and 8 for PR HEAD 1546d71d318d0d7c04909c72f16041147734118b in total

@jmguzik
Copy link
Contributor

jmguzik commented Jul 27, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2022
@jmguzik
Copy link
Contributor

jmguzik commented Jul 27, 2022

/hold
release when you feel it's ready

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2022
* Add the cloud resource names into openstack-conf-resourcenames
* Add secrets into openstack-conf-clouds
* Add infos for Bosko
* Configure quotas for 2 leases (for now)
@Sandeepyadav93
Copy link
Contributor Author

I created core-services/prow/02_config/_boskos.yaml manually, I should have used the automation "make boskos-config".

Looks like ordering matters(alphabetical) and I got the sequence wrong.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/30774/pull-ci-openshift-release-master-boskos-config-generation/1552244526335135744

@Sandeepyadav93 Sandeepyadav93 force-pushed the vexxhost-quota-slices branch from 1546d71 to fbe328d Compare July 27, 2022 12:15
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@Sandeepyadav93
Copy link
Contributor Author

@Sandeepyadav93
Copy link
Contributor Author

@bbguimaraes @jmguzik PR is ready from my understanding, The failing jobs under pj-rehearse don't seem related to this patch but I would defer to your confirmation.

@jmguzik
Copy link
Contributor

jmguzik commented Jul 28, 2022

/retest
Rehearsals are just rehearsals. They do not block. I'll issue a retest since we had problems with our platform when it was spinning.

@Sandeepyadav93
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

@Sandeepyadav93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-fips fbe328d link unknown /test pj-rehearse
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-techpreview-parallel fbe328d link unknown /test pj-rehearse
ci/rehearse/openshift/kuryr-kubernetes/master/e2e-openstack-kuryr fbe328d link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-verification-tests-master-nightly-4.10-upgrade-from-eus-4.8-openstack-ipi fbe328d link unknown /test pj-rehearse
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.10-e2e-openstack-ovn fbe328d link unknown /test pj-rehearse
ci/prow/pj-rehearse fbe328d link false /test pj-rehearse
ci/rehearse/openshift/cloud-provider-openstack/master/e2e-openstack-ccm-install fbe328d link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-extended-openstack-ipi fbe328d link unknown /test pj-rehearse
ci/rehearse/openshift/machine-api-provider-openstack/master/e2e-openstack-proxy fbe328d link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Sandeepyadav93
Copy link
Contributor Author

/release

@Sandeepyadav93
Copy link
Contributor Author

Sandeepyadav93 commented Aug 1, 2022

@bbguimaraes @jmguzik these rehearsal jobs failed in re-runs as well, Could you please help us in moving forward on this PR or If these failures are not related could we please merge this PR?

@hongkailiu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, hongkailiu, Sandeepyadav93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sandeepyadav93
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit fabadba into openshift:master Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

@Sandeepyadav93: Updated the following 2 configmaps:

  • ci-secret-bootstrap configmap in namespace ci at cluster app.ci using the following files:
    • key _config.yaml using file core-services/ci-secret-bootstrap/_config.yaml
  • resources configmap in namespace ci at cluster app.ci using the following files:
    • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml

In response to this:

  • Add the cloud resource names into openstack-conf-resourcenames
  • Add secrets into openstack-conf-clouds
  • Add infos for Bosko
  • Configure quotas for 2 leases (for now)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sandeepyadav93 Sandeepyadav93 deleted the vexxhost-quota-slices branch August 1, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants