Skip to content

OKD-240: rebase OKD node images on c10s #64007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

OKD-240: rebase OKD node images on c10s #64007

merged 1 commit into from
May 20, 2025

Conversation

jcapiitao
Copy link
Member

@jcapiitao jcapiitao commented Apr 17, 2025 •
edited
Loading

See the commit messages

Needs openshift/os#1806 and openshift-eng/ocp-build-data#6628 to be merged before

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2025
@jcapiitao jcapiitao changed the title openshift/os: rebase OKD node images on c10s NO-JIRA: rebase OKD node images on c10s Apr 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2025
@openshift-ci-robot
Copy link
Contributor

@jcapiitao: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcapiitao jcapiitao marked this pull request as ready for review April 17, 2025 16:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2025
@openshift-ci openshift-ci bot requested review from jlebon and madhu-pillai April 17, 2025 16:29
@Prashanth684
Copy link
Contributor

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

@openshift-ci-robot
Copy link
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcapiitao
Copy link
Member Author

/hold
we want it after branch cut

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2025
@jcapiitao
Copy link
Member Author

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

@openshift-ci-robot
Copy link
Contributor

@jcapiitao: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jcapiitao: This pull request explicitly references no jira issue.

In response to this:

See the commit messages

Needs openshift/os#1806 to be merged before

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025 •
edited
Loading

@jcapiitao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/os/master/okd-scos-images 60c3451 link unknown /pj-rehearse pull-ci-openshift-os-master-okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcapiitao jcapiitao mentioned this pull request Apr 22, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@jcapiitao: This pull request explicitly references no jira issue.

In response to this:

See the commit messages

Needs openshift/os#1806 and openshift-eng/ocp-build-data#6628 to be merged before

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcapiitao jcapiitao changed the title NO-JIRA: rebase OKD node images on c10s OKD-240: rebase OKD node images on c10s Apr 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 23, 2025 •
edited by openshift-ci bot
Loading

@jcapiitao: This pull request references OKD-240 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

See the commit messages

Needs openshift/os#1806 and openshift-eng/ocp-build-data#6628 to be merged before

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Prashanth684 Prashanth684 mentioned this pull request May 14, 2025
Closed
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jcapiitao: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-okd-scos-images openshift/os presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Prashanth684
Copy link
Contributor

/lgtm

@Prashanth684
Copy link
Contributor

i guess we merge this first and then openshift/os#1806 ? @jcapiitao

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcapiitao, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcapiitao
Copy link
Member Author

i guess we merge this first and then openshift/os#1806 ? @jcapiitao

Indeed, we should merge this one first to make the os patch pass CI

@Prashanth684
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 15, 2025
@Prashanth684
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 24a6288 into openshift:master May 20, 2025
13 checks passed
jcapiitao added a commit to jcapiitao/release that referenced this pull request May 27, 2025
@jcapiitao
OKD-240: rebase OKD node images on c10s (reapply)
158f50a 
This is a follow-up of [1] that was partially reverted by the
autoconfigbrancher job with [2].

[1] openshift#64007
[2] openshift#65157
@jcapiitao jcapiitao mentioned this pull request May 27, 2025
Merged
openshift-merge-bot bot pushed a commit that referenced this pull request May 28, 2025
@jcapiitao
OKD-240: rebase OKD node images on c10s (reapply) (#65370)
bf2cfd5 
This is a follow-up of [1] that was partially reverted by the
autoconfigbrancher job with [2].

[1] #64007
[2] #65157
abraham2512 pushed a commit to abraham2512/release that referenced this pull request May 29, 2025
@jcapiitao @abraham2512
openshift/os: rebase OKD node images on c10s (openshift#64007)
81adefa
abraham2512 pushed a commit to abraham2512/release that referenced this pull request May 29, 2025
@jcapiitao @abraham2512
OKD-240: rebase OKD node images on c10s (reapply) (openshift#65370)
0550c47 
This is a follow-up of [1] that was partially reverted by the
autoconfigbrancher job with [2].

[1] openshift#64007
[2] openshift#65157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prashanth684 Prashanth684 Prashanth684 left review comments

@jlebon jlebon Awaiting requested review from jlebon

@madhu-pillai madhu-pillai Awaiting requested review from madhu-pillai

Assignees

@Prashanth684 Prashanth684

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcapiitao @openshift-ci-robot @Prashanth684