Skip to content

OPRUN-3878: release-4.18: Add periodics for openshift-operator-framework-olm-release #64511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

camilamacedo86
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from bentito and dtfranz May 5, 2025 09:07
Copy link
Contributor

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 changed the title release-4.18: Add periodics for openshift-operator-framework-olm-release OCPBUGS-55696: release-4.18: Add periodics for openshift-operator-framework-olm-release May 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2025
@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: This pull request references Jira Issue OCPBUGS-55696, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title OCPBUGS-55696: release-4.18: Add periodics for openshift-operator-framework-olm-release OPRUN-3878: release-4.18: Add periodics for openshift-operator-framework-olm-release May 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 5, 2025

@camilamacedo86: This pull request references OPRUN-3878 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 5, 2025
@camilamacedo86
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 5, 2025

@camilamacedo86: This pull request references OPRUN-3878 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@camilamacedo86: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-operator-framework-olm-release-4.18-periodics-images openshift/operator-framework-olm presubmit Presubmit changed
periodic-ci-openshift-operator-framework-olm-release-4.18-periodics-e2e-gcp-olm N/A periodic Periodic changed
periodic-ci-openshift-operator-framework-olm-release-4.18-periodics-e2e-gcp-olm-flaky N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented May 5, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort
Copy link
Contributor

tmshort commented May 5, 2025

Compared to the main periodics:

  • Several tests are not present:
    • e2e-gcp-ovn
    • e2e-gcp-cponsole-olm
    • e2e-upgrade
  • a new docker file was added:
    • operator-framework-tools.Dockerfile

Why?

@camilamacedo86
Copy link
Contributor Author

Hi @tmshort

#64511 (comment)

We are doing the same thing that was done for 4.17.

We have introduced changes regarding the monorepo initiative. So, I suggest that we add the periodic for 4.18 as it is for 4.17, and then, if we need to add any other tests for 4.18 that do not exist for 4.17, we can go in a follow-up. WDYT?

@tmshort
Copy link
Contributor

tmshort commented May 8, 2025

Is this even the right location? Shouldn't these be in operator-framework-operator-controller if we're looking for default catalog test support?

@camilamacedo86
Copy link
Contributor Author

Close that was a mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants