Skip to content

Shard serial jobs in CNCC #65282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented May 22, 2025

These were hitting the 4 hour limit. Run them in 2 shards instead.

@openshift-ci openshift-ci bot requested review from danwinship and tssurya May 22, 2025 16:32
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mdbooth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-network-config-controller-master-e2e-aws-ovn-serial-1of2 openshift/cloud-network-config-controller presubmit Presubmit changed
pull-ci-openshift-cloud-network-config-controller-master-e2e-aws-ovn-serial-2of2 openshift/cloud-network-config-controller presubmit Presubmit changed
pull-ci-openshift-cloud-network-config-controller-master-e2e-azure-serial-1of2 openshift/cloud-network-config-controller presubmit Presubmit changed
pull-ci-openshift-cloud-network-config-controller-master-e2e-azure-serial-2of2 openshift/cloud-network-config-controller presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damdo, mdbooth
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hector-vido
Copy link
Contributor

/retest

@mdbooth
Copy link
Contributor Author

mdbooth commented May 22, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented May 22, 2025

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cloud-network-config-controller/master/e2e-aws-ovn-serial-1of2 021a309 link unknown /pj-rehearse pull-ci-openshift-cloud-network-config-controller-master-e2e-aws-ovn-serial-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member

damdo commented May 23, 2025

/retest

1 similar comment
@mdbooth
Copy link
Contributor Author

mdbooth commented May 27, 2025

/retest

@mdbooth
Copy link
Contributor Author

mdbooth commented May 27, 2025

/pj-rehearse pull-ci-openshift-cloud-network-config-controller-master-e2e-azure-serial-1of2
/pj-rehearse pull-ci-openshift-cloud-network-config-controller-master-e2e-aws-ovn-serial-1of2

@openshift-ci-robot
Copy link
Contributor

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mdbooth: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants