Skip to content

[th/dpu-operator-resolve-ip] change how to determine IP address of queue-manager (2) #65299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[th/dpu-operator-resolve-ip] change how to determine IP address of queue-manager (2) #65299

wants to merge 1 commit into from

Conversation

thom311
Copy link
Contributor

@thom311 thom311 commented May 23, 2025

Try again to resolve the DNS name from the queue-manager service running in MP+.

This is a re-spin of #64568

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thom311
Once this PR has been reviewed and has the lgtm label, please assign vrindle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thom311
Copy link
Contributor Author

thom311 commented May 23, 2025

/pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

@openshift-ci openshift-ci bot requested review from dgoodwin and neisw May 23, 2025 06:09
@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thom311 thom311 force-pushed the th/dpu-operator-resolve-ip branch from e930414 to 89f22bd Compare May 23, 2025 06:53
@thom311
Copy link
Contributor Author

thom311 commented May 23, 2025

/pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thom311
dpu-operator: resolve IP address dynamically
9c27d72 
The script talks to the queue-manager service (via HTTPS API).

That service runs in MP+ cluster, and we get the DNS name of the
openshift route from the vault.

So far, we could not resolve that DNS name, so the vault also configured
the IP address. The problem is, that the route periodically changes IP
address, so we need to frequently update the configuration (after it
breaks).

Instead, use the DNS servers from [1]. Those seem able to resolve this
name.

[1] https://github.com/openshift/release/blob/master/clusters/build-clusters/common_managed/dns.yaml
@thom311 thom311 force-pushed the th/dpu-operator-resolve-ip branch from 89f22bd to 9c27d72 Compare May 23, 2025 07:00
@thom311
Copy link
Contributor Author

thom311 commented May 23, 2025

/pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@thom311: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-dpu-operator-main-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.21-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.20-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.19-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.18-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.17-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.16-make-e2e-test openshift/dpu-operator presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@thom311
Copy link
Contributor Author

thom311 commented May 23, 2025

/pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thom311
Copy link
Contributor Author

thom311 commented May 23, 2025

/pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2025

@thom311: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/dpu-operator/main/make-e2e-test 9c27d72 link unknown /pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thom311
Copy link
Contributor Author

thom311 commented May 23, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@neisw neisw Awaiting requested review from neisw

Assignees
No one assigned
Labels
rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thom311 @openshift-ci-robot