aws: fix prebuilt artifacts upload #658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with uploading prebuilt artifacts by fixing variable quoting and region usage when registering the AMI. Key changes include:
- Correcting the variable expansion for the temporary JSON file.
- Updating the region variable from REGION to AWS_REGION.
- Minor formatting improvements.
Comments suppressed due to low confidence (2)
config/peerpods/podvm/aws-podvm-image-handler.sh:286
- Consider cleaning up the temporary file created with mktemp after its usage to avoid potential resource clutter.
local image_import_json_file=$(mktemp)
config/peerpods/podvm/aws-podvm-image-handler.sh:343
- The temporary file for registering the AMI is not removed after use; consider adding cleanup logic to improve maintainability.
local register_json_file=$(mktemp)
beraldoleal
reviewed
May 26, 2025
There was a problem hiding this comment.
Hi @snir911 do you mind adding details of the issue within the commit, please?
as it's currently complaining on missing region value Signed-off-by: Snir Sheriber <[email protected]>
snir911
force-pushed
the
oci-upload-fix-aws
branch
from
e137346 to
84668ca
Compare
|
@snir911: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
ami creation from an oci image is failing to upload
- What I did
- How to verify it
- Description for the changelog